Function _check_build_include_order

ci/lint_cpp/test_unity_build.py:354–486

Check that _build.cpp.hpp files have correct include ordering and section comments. Required structure (when both same-level AND subdir includes exist): // begin current directory includes #include "fl/channels/channel.cpp.hpp" ... // begin sub directory i

(src_dir: Path)

def _check_build_include_order(src_dir: Path) -> list[str]:
    """
    Check that _build.cpp.hpp files have correct include ordering and section comments.

    Required structure (when both same-level AND subdir includes exist):

        // begin current directory includes
        #include "fl/channels/channel.cpp.hpp"
        ...

        // begin sub directory includes
        #include "fl/channels/detail/_build.cpp.hpp"
        ...

    Rules:
    1. Same-level *.cpp.hpp includes BEFORE subdirectory _build.cpp.hpp includes.
    2. When both sections exist, require section comment markers with a blank line before each.
    3. Files with only one kind of include do NOT need section comments.

    Returns:
        list of violation strings
    """
    violations: list[str] = []

    include_pattern = re.compile(r'^\s*#include\s+"([^"]+\.cpp\.hpp)"', re.MULTILINE)

    for build_hpp in src_dir.rglob(BUILD_HPP):
        content = build_hpp.read_text(encoding="utf-8")
        lines = content.splitlines()
        namespace_path = _get_namespace_path(build_hpp, src_dir)
        if namespace_path is None:
            continue

        includes = list(include_pattern.finditer(content))
        if not includes:
            continue

        rel_file = build_hpp.relative_to(PROJECT_ROOT).as_posix()

        # Classify includes
        same_level_lines: list[int] = []
        subdir_lines: list[int] = []

        for match in includes:
            included_path = match.group(1)
            line_num = _get_line_number(content, match.start())

            if included_path.endswith(BUILD_HPP):
                subdir_lines.append(line_num)
            else:
                same_level_lines.append(line_num)

        has_both = bool(same_level_lines) and bool(subdir_lines)

        # Check ordering: all same-level must come before all subdir
        if has_both:
            last_same = max(same_level_lines)
            first_subdir = min(subdir_lines)