Function deleteDocumentStorageFiles

apps/sim/lib/knowledge/documents/service.ts:1847–1913

(
  documentsToDelete: Array<{ id: string; fileUrl: string | null; workspaceId?: string | null }>,
  requestId: string
)

}

export async function deleteDocumentStorageFiles(
  documentsToDelete: Array<{ id: string; fileUrl: string | null; workspaceId?: string | null }>,
  requestId: string
): Promise<void> {
  const entries = documentsToDelete.map((doc) => ({
    doc,
    storageKey: getKnowledgeBaseStorageKey(doc.fileUrl),
  }))

  // Resolve all kb/ ownership bindings in one query (avoids an N+1 across the
  // delete fan-out below).
  const kbKeys = [
    ...new Set(
      entries
        .map((entry) => entry.storageKey)
        .filter((key): key is string => typeof key === 'string' && key.startsWith('kb/'))
    ),
  ]
  const ownerByKey = new Map<string, string | null>()
  if (kbKeys.length > 0) {
    const bindings = await getFileMetadataByKeys(kbKeys, 'knowledge-base')
    for (const binding of bindings) {
      ownerByKey.set(binding.key, binding.workspaceId)
    }
  }

  await Promise.allSettled(
    entries.map(async ({ doc, storageKey }) => {
      if (!storageKey) {
        return
      }

      // Only delete a kb/ object when its trusted ownership binding confirms the
      // deleting document's workspace owns it. Prevents deleting another tenant's
      // object via a document with a planted fileUrl.
      if (storageKey.startsWith('kb/')) {
        const bindingWorkspaceId = ownerByKey.get(storageKey)
        if (!bindingWorkspaceId) {
          logger.warn(`[${requestId}] Skipping storage delete: no ownership binding for key`, {
            documentId: doc.id,
            storageKey,
          })
          return
        }
        if (!doc.workspaceId || bindingWorkspaceId !== doc.workspaceId) {
          logger.warn(`[${requestId}] Skipping storage delete: ownership binding mismatch`, {
            documentId: doc.id,
            storageKey,
            bindingWorkspaceId,
            documentWorkspaceId: doc.workspaceId ?? null,
          })
          return
        }
      }

      try {
        await deleteFile({ key: storageKey, context: 'knowledge-base' })
        await deleteFileMetadata(storageKey)