Function test_pkg_paths

tests/pytests/pkg/integration/test_salt_user.py:178–325

Test package paths ownership

(
    install_salt,
    pkg_paths,
    pkg_paths_salt_user,
    pkg_paths_salt_user_exclusions,
    salt_call_cli,
)

def test_pkg_paths(
    install_salt,
    pkg_paths,
    pkg_paths_salt_user,
    pkg_paths_salt_user_exclusions,
    salt_call_cli,
):
    """
    Test package paths ownership
    """
    if packaging.version.parse(install_salt.version) <= packaging.version.parse(
        "3006.4"
    ):
        pytest.skip("Package path ownership was changed in salt 3006.4")

    if install_salt.prev_version == "3007.1":
        pytest.xfail("Fails due to syndic permissions bug")

    if install_salt.distro_name == "photon" and install_salt.distro_version == "5":
        # Fails on upgrade tests but there is no way to check that we are running an upgrade test.
        pytest.skip("Package path ownership fails on photon 5")

    # Determine the expected owner for the minion and installation directory.
    # We check the minion configuration to see if a specific user is set.
    expected_minion_user = "root"
    ret = salt_call_cli.run("--local", "config.get", "user")
    if ret.returncode == 0 and ret.data:
        expected_minion_user = ret.data

    def _is_excluded(path):
        path_str = str(path)
        for excluded in pkg_paths_salt_user_exclusions:
            if path_str == excluded or path_str.startswith(f"{excluded}/"):
                return True
        return False

    def _is_minion_runtime_path(path):
        path_str = str(path)
        return any(
            path_str.startswith(prefix)
            for prefix in (
                "/etc/salt/minion",
                "/var/cache/salt/minion",
                "/var/log/salt/minion",
                "/var/run/salt/minion",
                "/run/salt/minion",
            )
        )

    def _deb_downgrade_legacy_salt_paths_allow_root():
        """
        Pre-3007 .deb layouts often left master/cache log trees root-owned. After a
        downgrade to 3006.x, those paths match ``pkg_paths_salt_user`` but are not
        salt:salt like current packages.
        """
        return (
            install_salt.use_prev_version
            and install_salt.distro_id in ("debian", "ubuntu")