Class TestReleaseConnection

tests/test_etag.py:145–177

On 304s we still make a request using our connection pool, yet we do not call the parent adapter, which releases the connection back to the pool. This test ensures that when the parent `get` method is not called we consume the response (which should be empty according to the HTT

class TestReleaseConnection:
    """
    On 304s we still make a request using our connection pool, yet
    we do not call the parent adapter, which releases the connection
    back to the pool. This test ensures that when the parent `get`
    method is not called we consume the response (which should be
    empty according to the HTTP spec) and release the connection.
    """

    def test_not_modified_releases_connection(self, server, url):
        sess = CacheControl(requests.Session())
        etag_url = urljoin(url, "/etag")
        sess.get(etag_url)

        resp = Mock(status=304, headers={})

        # These are various ways the the urllib3 response can created
        # in requests.adapters.  Which one is actually used depends
        # on which version if `requests` is in use, as well as perhaps
        # other parameters.
        response_mods = [
            "requests.adapters.HTTPResponse.from_httplib",
            "urllib3.HTTPConnectionPool.urlopen",
        ]

        with ExitStack() as stack:
            for mod in response_mods:
                with suppress(ImportError, AttributeError):
                    stack.enter_context(patch(mod, Mock(return_value=resp)))

            sess.get(etag_url)
            assert resp.read.called
            assert resp.release_conn.called