Function TestAppendHistogramErrorDoesNotSetPendingCommit

tsdb/head_test.go:5723–5768

TestAppendHistogramErrorDoesNotSetPendingCommit verifies that when AppendHistogram fails with a sample-validation error (e.g. out-of-order), the existing memSeries's pendingCommit flag is not left set to true. A stuck pendingCommit flag keeps the series alive across head GC even though no samples ar

(t *testing.T)

// A stuck pendingCommit flag keeps the series alive across head GC even
// though no samples are pending for it.
func TestAppendHistogramErrorDoesNotSetPendingCommit(t *testing.T) {
	for _, tc := range []struct {
		name string
		h    *histogram.Histogram
		fh   *histogram.FloatHistogram
	}{
		{name: "integer", h: tsdbutil.GenerateTestHistogram(0)},
		{name: "float", fh: tsdbutil.GenerateTestFloatHistogram(0)},
	} {
		t.Run(tc.name, func(t *testing.T) {
			head, _ := newTestHead(t, 1000, compression.None, false)
			require.NoError(t, head.Init(0))

			lbls := labels.FromStrings("a", "b")

			// Seed an in-order sample so the series exists with maxTime=200.
			app := head.Appender(context.Background())
			_, err := app.AppendHistogram(0, lbls, 200, tc.h, tc.fh)
			require.NoError(t, err)
			require.NoError(t, app.Commit())

			ms, _, err := head.getOrCreate(lbls.Hash(), lbls, false)
			require.NoError(t, err)
			require.NotNil(t, ms)
			ms.Lock()
			pc := ms.pendingCommit
			ms.Unlock()
			require.False(t, pc, "pendingCommit should be cleared after a successful commit")

			// Attempt an out-of-order append: same series, earlier timestamp,
			// OOO time window disabled. appendableHistogram returns
			// ErrOutOfOrderSample, so the sample is never recorded in the
			// appender's batch and Commit/Rollback never clears pendingCommit
			// for this series.
			app = head.Appender(context.Background())
			_, err = app.AppendHistogram(0, lbls, 100, tc.h, tc.fh)
			require.ErrorIs(t, err, storage.ErrOutOfOrderSample)
			require.NoError(t, app.Rollback())

			ms.Lock()
			pc = ms.pendingCommit
			ms.Unlock()
			require.False(t, pc, "pendingCommit should remain false after a failed AppendHistogram")
		})
	}
}

// Tests https://github.com/prometheus/prometheus/issues/9725.
func TestChunkSnapshotReplayBug(t *testing.T) {