Function TestInstall_wrapperChainOrder

internal/hook/install_test.go:86–127

Wrap chain composes outermost-first (registration order). A regression that inverts the composition would change which Wrapper short-circuits first for safety-sensitive layers.

(t *testing.T)

// that inverts the composition would change which Wrapper short-circuits
// first for safety-sensitive layers.
func TestInstall_wrapperChainOrder(t *testing.T) {
	root := &cobra.Command{Use: "lark-cli"}
	var order []string
	leaf := &cobra.Command{Use: "+x", RunE: func(*cobra.Command, []string) error {
		order = append(order, "RunE")
		return nil
	}}
	root.AddCommand(leaf)

	reg := hook.NewRegistry()
	reg.AddWrapper(hook.WrapperEntry{
		Name: "outer", Selector: platform.All(),
		Fn: func(next platform.Handler) platform.Handler {
			return func(ctx context.Context, inv platform.Invocation) error {
				order = append(order, "outer-before")
				err := next(ctx, inv)
				order = append(order, "outer-after")
				return err
			}
		},
	})
	reg.AddWrapper(hook.WrapperEntry{
		Name: "inner", Selector: platform.All(),
		Fn: func(next platform.Handler) platform.Handler {
			return func(ctx context.Context, inv platform.Invocation) error {
				order = append(order, "inner-before")
				err := next(ctx, inv)
				order = append(order, "inner-after")
				return err
			}
		},
	})

	hook.Install(root, reg, fakeViewSource{view: fakeView{path: "+x"}})
	if err := leaf.RunE(leaf, nil); err != nil {
		t.Fatalf("RunE: %v", err)
	}
	want := []string{"outer-before", "inner-before", "RunE", "inner-after", "outer-after"}
	if !equalStrings(order, want) {
		t.Fatalf("Wrapper order = %v, want %v", order, want)
	}
}

// Denial guard physical isolation: the most safety-critical invariant.
// A denied command must NEVER reach a Wrap chain. We register a Wrap