Function TestUpdateCommand_RealSkillsSyncRewritesState

cmd/update/update_test.go:1381–1488

TestUpdateCommand_RealSkillsSyncRewritesState is a live integration test that verifies "lark-cli update" correctly triggers skills sync and rewrites the state file. It calls the real npx skills CLI, so the test is skipped when npx or the skills registry is unavailable (e.g. no network or fork PRs).

(t *testing.T)

// state file. It calls the real npx skills CLI, so the test is skipped when
// npx or the skills registry is unavailable (e.g. no network or fork PRs).
func TestUpdateCommand_RealSkillsSyncRewritesState(t *testing.T) {
	// Phase 1: Verify the real npx skills CLI is available; skip otherwise.
	if _, err := exec.LookPath("npx"); err != nil {
		t.Skipf("npx not found in PATH: %v", err)
	}
	ctx, cancel := context.WithTimeout(context.Background(), 45*time.Second)
	defer cancel()
	if err := exec.CommandContext(ctx, "npx", "-y", "skills", "add", "https://open.feishu.cn", "--list").Run(); err != nil {
		t.Skipf("real skills CLI unavailable: %v", err)
	}
	globalOut, err := exec.CommandContext(ctx, "npx", "-y", "skills", "ls", "-g").Output()
	if err != nil {
		t.Skipf("real global skills CLI unavailable: %v", err)
	}
	localSkills := skillscheck.ParseSkillsList(string(globalOut))
	if err := ctx.Err(); err != nil {
		t.Skipf("real skills CLI availability check timed out: %v", err)
	}

	// Phase 2: Seed a previous sync state simulating an upgrade from v1.0.19.
	// lark-doc and lark-mail are recorded as skipped/deleted, meaning the user
	// intentionally removed them while they were still official skills.
	t.Setenv("LARKSUITE_CLI_CONFIG_DIR", t.TempDir())
	before := skillscheck.SkillsState{
		Version:              "1.0.19",
		OfficialSkills:       []string{"lark-approval", "lark-attendance", "lark-base", "lark-calendar", "lark-contact", "lark-doc", "lark-drive", "lark-event", "lark-im", "lark-mail", "lark-markdown", "lark-minutes", "lark-okr", "lark-openapi-explorer", "lark-shared", "lark-sheets", "lark-skill-maker", "lark-slides", "lark-task", "lark-vc", "lark-vc-agent", "lark-whiteboard", "lark-wiki", "lark-workflow-meeting-summary", "lark-workflow-standup-report"},
		UpdatedSkills:        []string{"lark-approval", "lark-apps", "lark-attendance", "lark-base", "lark-calendar", "lark-contact", "lark-doc", "lark-drive", "lark-event", "lark-im", "lark-mail", "lark-markdown", "lark-minutes", "lark-okr", "lark-openapi-explorer", "lark-shared", "lark-sheets", "lark-skill-maker", "lark-slides", "lark-task", "lark-vc", "lark-vc-agent", "lark-whiteboard", "lark-wiki", "lark-workflow-meeting-summary", "lark-workflow-standup-report"},
		AddedOfficialSkills:  []string{},
		SkippedDeletedSkills: []string{},
		UpdatedAt:            "2026-05-20T00:00:00Z",
	}
	if err := skillscheck.WriteState(before); err != nil {
		t.Fatal(err)
	}
	state, readable, err := skillscheck.ReadState()
	if err != nil || !readable {
		t.Fatalf("ReadState() before update = (_, %v, %v), want readable", readable, err)
	}
	if state.Version != "1.0.19" {
		t.Fatalf("state.Version before update = %q, want 1.0.19", state.Version)
	}

	// Phase 3: Mock version functions so the update command believes it has
	// upgraded from 1.0.19 to 1.0.20, then execute "lark-cli update --json".
	// This triggers SyncSkills which calls the real npx skills add command.
	origFetch := fetchLatest
	origVersion := currentVersion
	t.Cleanup(func() { fetchLatest = origFetch; currentVersion = origVersion })
	fetchLatest = func() (string, error) { return "1.0.20", nil }
	currentVersion = func() string { return "1.0.20" }

	f, stdout, _ := newTestFactory(t)
	cmd := NewCmdUpdate(f)
	cmd.SetArgs([]string{"--json"})
	if err := cmd.Execute(); err != nil {
		t.Fatalf("lark-cli update --json err = %v, want nil", err)
	}