Function TestWriteDevboxShellrcZDOTDIRWithSpaces

internal/devbox/shell_test.go:497–549

TestWriteDevboxShellrcZDOTDIRWithSpaces guards against a regression where the `[ -f ]` guard around sourcing the user's shellrc was unquoted. When ZDOTDIR contains spaces (e.g. ".../Application Support/..."), the unquoted path expands to multiple words and `[` fails with "too many arguments",

(t *testing.T)

// path expands to multiple words and `[` fails with "too many arguments", so
// the user's real shellrc never gets sourced.
func TestWriteDevboxShellrcZDOTDIRWithSpaces(t *testing.T) {
	// A ZDOTDIR with a space, like the one some terminal integrations inject.
	zdotdir := filepath.Join(t.TempDir(), "Application Support", "zsh")
	if err := os.MkdirAll(zdotdir, 0o755); err != nil {
		t.Fatal(err)
	}
	t.Setenv("ZDOTDIR", zdotdir)

	zshrcPath := filepath.Join(zdotdir, ".zshrc")
	if err := os.WriteFile(zshrcPath, []byte("# user zshrc"), 0o644); err != nil {
		t.Fatalf("Failed to create test .zshrc: %v", err)
	}

	shell := initShellBinaryFields("/usr/bin/zsh")
	shell.devbox = &Devbox{projectDir: "/test/project"}
	shell.projectDir = "/test/project"

	shellrcPath, err := shell.writeDevboxShellrc()
	if err != nil {
		t.Fatalf("Failed to write devbox shellrc: %v", err)
	}
	content, err := os.ReadFile(shellrcPath)
	if err != nil {
		t.Fatalf("Failed to read generated shellrc: %v", err)
	}
	contentStr := string(content)

	// The guard must quote the path so the space doesn't split into words.
	wantGuard := `if [ -f "` + zshrcPath + `" ]; then`
	if !strings.Contains(contentStr, wantGuard) {
		t.Errorf("expected quoted guard %q in generated shellrc:\n%s", wantGuard, contentStr)
	}

	// Run the actual generated guard line through /bin/sh to prove it doesn't
	// error with "too many arguments" on a space-containing path.
	var guardLine string
	for _, line := range strings.Split(contentStr, "\n") {
		if strings.HasPrefix(strings.TrimSpace(line), "if [ -f ") {
			guardLine = strings.TrimSpace(line) + " echo sourced; fi"
			break
		}
	}
	if guardLine == "" {
		t.Fatalf("could not find guard line in generated shellrc:\n%s", contentStr)
	}
	out, err := exec.Command("/bin/sh", "-c", guardLine).CombinedOutput()
	if err != nil {
		t.Fatalf("guard line failed to execute (%v): %s\nline: %s", err, out, guardLine)
	}
	if strings.TrimSpace(string(out)) != "sourced" {
		t.Errorf("guard line did not take the true branch; output: %q\nline: %s", out, guardLine)
	}
}