Function TestInsidersRoutePreservesUIMeta

pkg/http/handler_test.go:871–906

TestInsidersRoutePreservesUIMeta is a regression test for the bug where _meta.ui was stripped from tools/list responses on the HTTP /insiders route. Before the fix: - buildStaticInventory called Build() on a builder configured with the HTTP feature checker (which reads insiders mode from the reques

(t *testing.T)

//   - RegisterTools applies the strip per-request, using the request context
//     where the HTTP feature checker correctly observes insiders mode.
func TestInsidersRoutePreservesUIMeta(t *testing.T) {
	const uiURI = "ui://test/widget"
	uiTool := mockTool("with_ui", "repos", true)
	uiTool.Tool.Meta = mcp.Meta{"ui": map[string]any{"resourceUri": uiURI}}

	checker := createHTTPFeatureChecker(nil, false)
	build := func() *inventory.Inventory {
		inv, err := inventory.NewBuilder().
			SetTools([]inventory.ServerTool{uiTool}).
			WithFeatureChecker(checker).
			WithToolsets([]string{"all"}).
			Build()
		require.NoError(t, err)
		return inv
	}

	// Simulate a /insiders request: ctx has insiders mode set.
	insidersCtx := ghcontext.WithInsidersMode(context.Background(), true)

	// AvailableTools no longer strips _meta.ui (post-fix), regardless of ctx.
	// The strip lives in RegisterTools, gated on the per-request FF check.
	insidersTools := build().AvailableTools(insidersCtx)
	plainTools := build().AvailableTools(context.Background())

	// On the /insiders path, the FF check returns true → no strip → _meta preserved.
	enabled, _ := checker(insidersCtx, "remote_mcp_ui_apps")
	require.True(t, enabled, "FF should be on for /insiders ctx")
	require.Len(t, insidersTools, 1)
	require.NotNil(t, insidersTools[0].Tool.Meta, "_meta should be present on /insiders")
	require.Equal(t, uiURI, insidersTools[0].Tool.Meta["ui"].(map[string]any)["resourceUri"])

	// On the non-insiders path, RegisterTools strips _meta.ui.
	plainEnabled, _ := checker(context.Background(), "remote_mcp_ui_apps")
	require.False(t, plainEnabled, "FF should be off for non-insiders ctx")
	require.Len(t, plainTools, 1)
}

// TestUIMetaStrippedWhenClientLacksCapability verifies that even on the
// /insiders path (where the feature flag is on), UI metadata is stripped from