Function Test_issueWriteSchemaClassification

pkg/github/issues_test.go:1605–1641

Test_issueWriteSchemaClassification fails when a schema property is added without classifying it as either form-resendable (issueWriteFormParams) or known-non-form (knownNonForm below). Without this guard, an unclassified property would silently flip UI gating: form-incompatible fields would stop tr

(t *testing.T)

// property would silently flip UI gating: form-incompatible fields would
// stop tripping the safety-net bypass and the form would drop their values.
func Test_issueWriteSchemaClassification(t *testing.T) {
	t.Parallel()

	// Schema properties the MCP App form cannot represent — their presence
	// must trigger the safety-net bypass via hasNonFormParams. The
	// form currently collects every schema property, so this allowlist is
	// empty; add a property here only if it is added to the schema without
	// corresponding form support.
	knownNonForm := map[string]struct{}{}

	cases := []struct {
		name string
		tool inventory.ServerTool
	}{
		{name: "IssueWrite", tool: IssueWrite(translations.NullTranslationHelper)},
	}

	for _, tc := range cases {
		t.Run(tc.name, func(t *testing.T) {
			t.Parallel()
			schema, ok := tc.tool.Tool.InputSchema.(*jsonschema.Schema)
			require.True(t, ok, "InputSchema should be *jsonschema.Schema")

			for prop := range schema.Properties {
				_, isForm := issueWriteFormParams[prop]
				_, isNonForm := knownNonForm[prop]

				assert.Falsef(t, isForm && isNonForm,
					"property %q is classified as both form-resendable and non-form — pick one", prop)
				assert.Truef(t, isForm || isNonForm,
					"property %q in %s schema is unclassified — add it to issueWriteFormParams (pkg/github/issues.go) "+
						"if the MCP App form can carry it on submit, otherwise add it to the knownNonForm allowlist in this test",
					prop, tc.name)
			}
		})
	}
}

func Test_ListIssues(t *testing.T) {
	// Verify tool definition