Function TestResolveFeatureFlags

pkg/github/feature_flags_test.go:137–218

(t *testing.T)

}

func TestResolveFeatureFlags(t *testing.T) {
	t.Parallel()

	tests := []struct {
		name            string
		enabledFeatures []string
		insidersMode    bool
		expectedFlags   []string
		unexpectedFlags []string
	}{
		{
			name:            "no features, no insiders",
			enabledFeatures: nil,
			expectedFlags:   nil,
			unexpectedFlags: []string{MCPAppsFeatureFlag},
		},
		{
			name:            "explicit feature enabled",
			enabledFeatures: []string{MCPAppsFeatureFlag},
			expectedFlags:   []string{MCPAppsFeatureFlag},
		},
		{
			name:            "insiders mode enables insiders flags",
			enabledFeatures: nil,
			insidersMode:    true,
			expectedFlags:   InsidersFeatureFlags,
		},
		{
			name:            "insiders mode does not auto-enable ifc labels",
			enabledFeatures: nil,
			insidersMode:    true,
			unexpectedFlags: []string{FeatureFlagIFCLabels},
		},
		{
			name:            "ifc_labels can be directly enabled",
			enabledFeatures: []string{FeatureFlagIFCLabels},
			expectedFlags:   []string{FeatureFlagIFCLabels},
		},
		{
			name:            "unknown flags are filtered out",
			enabledFeatures: []string{"unknown_flag", "another_unknown"},
			unexpectedFlags: []string{"unknown_flag", "another_unknown"},
		},
		{
			name:            "mix of known and unknown flags",
			enabledFeatures: []string{MCPAppsFeatureFlag, "unknown_flag"},
			expectedFlags:   []string{MCPAppsFeatureFlag},
			unexpectedFlags: []string{"unknown_flag"},
		},
		{
			name:            "user-only flags can be enabled but are not turned on by insiders",
			enabledFeatures: []string{FeatureFlagIssuesGranular},
			insidersMode:    false,
			expectedFlags:   []string{FeatureFlagIssuesGranular},
		},
		{
			name:            "insiders does not enable user-only allowed flags",
			enabledFeatures: nil,