Function TestCreateOAuthMiddleware

internal/ghmcp/oauth_test.go:260–333

(t *testing.T)

}

func TestCreateOAuthMiddleware(t *testing.T) {
	t.Parallel()

	const nextText = "handler-ran"
	newNext := func(called *bool) mcp.MethodHandler {
		return func(_ context.Context, _ string, _ mcp.Request) (mcp.Result, error) {
			*called = true
			return &mcp.CallToolResult{Content: []mcp.Content{&mcp.TextContent{Text: nextText}}}, nil
		}
	}

	t.Run("non tool call passes through without authenticating", func(t *testing.T) {
		t.Parallel()
		fake := &fakeAuthenticator{hasToken: false}
		var called bool
		mw := createOAuthMiddleware(fake, discardLogger())
		_, err := mw(newNext(&called))(context.Background(), "initialize", &mcp.InitializeRequest{})
		require.NoError(t, err)
		assert.True(t, called, "next should run")
		assert.Zero(t, fake.authCalls, "authentication must not run for non tool calls")
	})

	t.Run("existing token short circuits authentication", func(t *testing.T) {
		t.Parallel()
		fake := &fakeAuthenticator{hasToken: true}
		var called bool
		mw := createOAuthMiddleware(fake, discardLogger())
		_, err := mw(newNext(&called))(context.Background(), "tools/call", &mcp.CallToolRequest{})
		require.NoError(t, err)
		assert.True(t, called, "next should run")
		assert.Zero(t, fake.authCalls, "authentication must be skipped when a token already exists")
	})

	t.Run("successful authentication proceeds to handler", func(t *testing.T) {
		t.Parallel()
		fake := &fakeAuthenticator{hasToken: false, outcome: nil, err: nil}
		var called bool
		mw := createOAuthMiddleware(fake, discardLogger())
		res, err := mw(newNext(&called))(context.Background(), "tools/call", &mcp.CallToolRequest{})
		require.NoError(t, err)
		assert.Equal(t, 1, fake.authCalls)
		assert.True(t, called, "next should run once authorized")
		callRes, ok := res.(*mcp.CallToolResult)
		require.True(t, ok)
		require.Len(t, callRes.Content, 1)
		assert.Equal(t, nextText, callRes.Content[0].(*mcp.TextContent).Text)
	})

	t.Run("pending user action is surfaced as a tool result", func(t *testing.T) {
		t.Parallel()
		const message = "Open https://example.com/auth to authorize, then retry."
		fake := &fakeAuthenticator{hasToken: false, outcome: &oauth.Outcome{UserAction: &oauth.UserAction{Message: message}}}
		var called bool
		mw := createOAuthMiddleware(fake, discardLogger())
		res, err := mw(newNext(&called))(context.Background(), "tools/call", &mcp.CallToolRequest{})
		require.NoError(t, err)
		assert.False(t, called, "next must not run while the user still needs to authorize")
		callRes, ok := res.(*mcp.CallToolResult)