Method validateModelAliasMap

pkg/workflow/model_alias_validation.go:95–155

validateModelAliasMap is the main entry point for compile-time model-alias validation. It validates: - The user-supplied alias map entries in frontmatterModels (V-MAF-001..006, V-MAF-011). - The engine.model value (V-MAF-001, V-MAF-004, V-MAF-006). - Circular references across the fully-merged alias

(
	mergedAliasMap map[string][]string,
	frontmatterModels map[string][]string,
	engineModel string,
	markdownPath string,
)

// Returns a non-nil error (causing compilation to abort) for hard violations.
// Warnings are printed to stderr via the compiler's warning counter.
func (c *Compiler) validateModelAliasMap(
	mergedAliasMap map[string][]string,
	frontmatterModels map[string][]string,
	engineModel string,
	markdownPath string,
) error {
	modelAliasValidationLog.Printf("Validating model alias map: %d merged entries, %d frontmatter entries, engine.model=%q",
		len(mergedAliasMap), len(frontmatterModels), engineModel)

	// V-MAF-004: engine.model MUST NOT contain a glob pattern ("*").
	// The check is always performed, but only on the *literal* parts of the
	// value — expression segments (${{ ... }}) are stripped first so that a
	// "*" inside an expression body (e.g. "${{ contains(inputs.m, '*') }}")
	// is not falsely flagged.  A "*" that appears *outside* an expression
	// (e.g. "${{ inputs.model }}*" or "copilot/*${{ inputs.model }}") is
	// still a glob and must be rejected.
	if engineModel != "" {
		literalText := ExpressionPattern.ReplaceAllString(engineModel, "")
		if strings.Contains(literalText, "*") {
			return formatCompilerError(markdownPath, "error",
				fmt.Sprintf("engine.model: glob patterns are not allowed in engine.model; "+
					"got %q — glob patterns may only appear in models alias list entries (V-MAF-004)", engineModel),
				nil)
		}
		// Syntax and parameter checks ($-character parsing, known params) are
		// skipped for runtime-resolved expressions — they cannot be parsed at
		// compile time.
		if !containsExpression(engineModel) {
			// V-MAF-001 + V-MAF-006: validate syntax of engine.model.
			if errs := validateModelIdentifierStrings([]string{engineModel}, "engine.model"); len(errs) > 0 {
				return formatCompilerError(markdownPath, "error", errs[0], nil)
			}
			// V-MAF-011: warn about unrecognised parameter keys in engine.model.
			c.warnUnrecognizedModelParams([]string{engineModel}, markdownPath)
		}
	}

	// Validate user-supplied frontmatter aliases only (builtins are pre-validated).
	for key, entries := range frontmatterModels {
		// V-MAF-005: alias keys MUST NOT contain "/", "?", or "&".
		if err := validateAliasKey(key, markdownPath); err != nil {
			return err
		}

		// V-MAF-001 + V-MAF-002 + V-MAF-003 + V-MAF-006: validate each entry string.
		if errs := validateModelIdentifierStrings(entries, "models."+displayKey(key)); len(errs) > 0 {
			return formatCompilerError(markdownPath, "error", errs[0], nil)
		}

		// V-MAF-011: warn about unrecognised parameter keys in each entry.
		c.warnUnrecognizedModelParams(entries, markdownPath)
	}

	// V-MAF-010: detect circular alias references across the merged map.
	if err := detectCircularModelAliases(mergedAliasMap, markdownPath); err != nil {
		return err
	}