Function TestExplicitModelConfigOverridesEnvVar

pkg/workflow/model_env_vars_test.go:178–226

TestExplicitModelConfigOverridesEnvVar tests that explicit model configuration takes precedence

(t *testing.T)

// TestExplicitModelConfigOverridesEnvVar tests that explicit model configuration takes precedence
func TestExplicitModelConfigOverridesEnvVar(t *testing.T) {
	workflowData := &WorkflowData{
		Name: "test-explicit-model",
		AI:   "copilot",
		EngineConfig: &EngineConfig{
			ID:    "copilot",
			Model: "gpt-4",
		},
		Tools: map[string]any{
			"bash": []any{"echo"},
		},
		SafeOutputs: &SafeOutputsConfig{
			// Just enough to make it an agent job
		},
	}

	engine, err := GetGlobalEngineRegistry().GetEngine("copilot")
	if err != nil {
		t.Fatalf("Failed to get engine: %v", err)
	}

	steps := engine.GetExecutionSteps(workflowData, "/tmp/test.log")

	// Convert steps to string
	var stepsStr strings.Builder
	for _, step := range steps {
		for _, line := range step {
			stepsStr.WriteString(line)
			stepsStr.WriteString("\n")
		}
	}
	stepsContent := stepsStr.String()

	// When model is explicitly configured, the GH_AW_ fallback env var should NOT be present
	if strings.Contains(stepsContent, constants.EnvVarModelAgentCopilot+":") {
		t.Errorf("Fallback env var %s should not be present when model is explicitly configured", constants.EnvVarModelAgentCopilot)
	}

	// The model should be passed via the native COPILOT_MODEL env var (not via --model flag)
	expectedEnvLine := constants.CopilotCLIModelEnvVar + ": gpt-4"
	if !strings.Contains(stepsContent, expectedEnvLine) {
		t.Errorf("Expected native env var line '%s' not found in steps:\n%s", expectedEnvLine, stepsContent)
	}

	// The --model flag should NOT appear in the shell command (model is via env var)
	if strings.Contains(stepsContent, "--model gpt-4") {
		t.Errorf("--model flag should not be in command when model is set via native env var:\n%s", stepsContent)
	}
}

// TestCopilotFallbackModelMapsToNativeEnvVar tests that when model is not explicitly configured,
// the Copilot engine maps the GitHub org variable to the native COPILOT_MODEL env var instead