Function TestParserMCPErrorMessageQuality

pkg/workflow/mcp_error_messages_test.go:147–333

TestParserMCPErrorMessageQuality verifies error messages in pkg/parser/mcp.go

(t *testing.T)

// TestParserMCPErrorMessageQuality verifies error messages in pkg/parser/mcp.go
func TestParserMCPErrorMessageQuality(t *testing.T) {
	tests := []struct {
		name          string
		toolName      string
		mcpSection    any
		toolConfig    map[string]any
		expectError   bool
		errorContains []string
		errorShould   string
	}{
		{
			name:        "invalid mcp configuration format - wrong type",
			toolName:    "my-tool",
			mcpSection:  12345, // should be map or string
			toolConfig:  map[string]any{},
			expectError: true,
			errorContains: []string{
				"mcp configuration must be a map or JSON string",
				"got int",
				"Example:",
				"mcp-servers:",
				"my-tool:",
				"command:",
			},
			errorShould: "show received type and provide example",
		},
		{
			name:     "type field must be string",
			toolName: "my-tool",
			mcpSection: map[string]any{
				"type":    123, // should be string
				"command": "npx",
			},
			toolConfig:  map[string]any{},
			expectError: true,
			errorContains: []string{
				"type field must be a string",
				"got int",
				"Valid types are: stdio, http",
				"Example:",
				"type: stdio",
			},
			errorShould: "show received type, list valid types, and provide example",
		},
		{
			name:     "stdio missing command or container",
			toolName: "incomplete",
			mcpSection: map[string]any{
				"type": "stdio",
				"args": []string{"--port", "3000"},
			},
			toolConfig:  map[string]any{},
			expectError: true,
			errorContains: []string{
				"stdio MCP tool",
				"must specify either 'command' or 'container'",
				"Cannot specify both",
				"Example with command:",