Function TestBuildHelpfulParamError

pkg/cli/mcp_argument_validation_test.go:165–203

TestBuildHelpfulParamError verifies the structure of the helpful error message.

(t *testing.T)

// TestBuildHelpfulParamError verifies the structure of the helpful error message.
func TestBuildHelpfulParamError(t *testing.T) {
	t.Run("single unknown param with suggestion", func(t *testing.T) {
		msg := buildHelpfulParamError(
			"compile",
			[]string{"workflow-name"},
			[]string{"workflows", "strict"},
		)
		assert.Contains(t, msg, "Unknown parameter 'workflow-name'", "should mention unknown param")
		assert.Contains(t, msg, "Did you mean 'workflows'?", "should suggest workflows")
		assert.Contains(t, msg, "agenticworkflows compile --help", "should point to help")
	})

	t.Run("single unknown param without suggestion", func(t *testing.T) {
		msg := buildHelpfulParamError(
			"compile",
			[]string{"banana"},
			[]string{"workflows", "strict"},
		)
		assert.Contains(t, msg, "Unknown parameter 'banana'", "should mention unknown param")
		assert.NotContains(t, msg, "Did you mean", "should not suggest for unrelated param")
		assert.Contains(t, msg, "agenticworkflows compile --help", "should point to help")
	})

	t.Run("multiple unknown params", func(t *testing.T) {
		msg := buildHelpfulParamError(
			"compile",
			[]string{"workflow-name", "abc"},
			[]string{"workflows", "strict"},
		)
		assert.Contains(t, msg, "Unknown parameter 'workflow-name'", "should mention first unknown param")
		assert.Contains(t, msg, "Unknown parameter 'abc'", "should mention second unknown param")
		assert.Contains(t, msg, "agenticworkflows compile --help", "should point to help")
	})

	t.Run("empty tool name omits help line", func(t *testing.T) {
		msg := buildHelpfulParamError("", []string{"workflow-name"}, []string{"workflows"})
		assert.NotContains(t, msg, "--help", "no tool name means no help line")
	})
}

// TestArgumentValidationMiddleware_TransformsAdditionalPropertiesError verifies
// that the middleware replaces raw schema validation errors with helpful messages.