Function TestKnownProviderGatesFetch

pkg/modelsdev/store_test.go:52–81

TestKnownProviderGatesFetch is the regression test for issue #3165: a lookup for a provider the knownProvider predicate rejects (a user-defined custom provider) must resolve locally without ever fetching the models.dev catalog, while a known provider may still trigger a fetch.

(t *testing.T)

// provider) must resolve locally without ever fetching the models.dev catalog,
// while a known provider may still trigger a fetch.
func TestKnownProviderGatesFetch(t *testing.T) {
	t.Parallel()

	// A cache path that does not exist, so there is no on-disk catalog to fall
	// back on — the cold-start situation from the issue.
	cacheFile := filepath.Join(t.TempDir(), "models_dev.json")
	fetched, fetch := trackingFetcher()
	store, err := NewStore(
		WithCache(cacheFile),
		WithKnownProvider(func(p string) bool { return p == "openai" }),
		WithFetcher(fetch),
	)
	require.NoError(t, err)

	ctx := expiredContext(t)

	// Custom provider: not known -> resolves locally, no network attempt.
	*fetched = false
	_, err = store.GetModel(ctx, NewID("mistral_gateway", "mistral-small-latest"))
	require.Error(t, err)
	assert.False(t, *fetched, "custom provider must not trigger a models.dev fetch")
	assert.Contains(t, err.Error(), `provider "mistral_gateway" not found`)

	// Known provider: a cold cache still warrants a fetch — confirming the gate
	// did not disable fetching wholesale. The fetch fails here (unreachable
	// network) so the lookup falls back to the embedded snapshot.
	*fetched = false
	_, _ = store.GetModel(ctx, NewID("openai", "gpt-4o"))
	assert.True(t, *fetched, "known provider must still fetch the catalog when the cache is cold")
}

// TestNoPredicateAlwaysAllowsFetch guards the default, backwards-compatible
// behaviour: with no knownProvider predicate every provider may fetch.