Function TestValidateCompositeCommand

pkg/validation/commands_test.go:297–384

(t *testing.T)

}

func TestValidateCompositeCommand(t *testing.T) {

	component := "alias1"
	validExecCommands := []v1alpha2.Command{
		generateDummyExecCommand("command1", component, &v1alpha2.CommandGroup{Kind: runGroup}),
		generateDummyExecCommand("command2", component, &v1alpha2.CommandGroup{Kind: buildGroup}),
		generateDummyExecCommand("command3", component, &v1alpha2.CommandGroup{Kind: runGroup}),
	}
	components := []v1alpha2.Component{
		generateDummyContainerComponent(component, nil, nil, nil, v1alpha2.Annotation{}, false),
	}

	invalidCmdErr := ".*command does not map to a valid component"
	missingCmdErr := ".*the command .* mentioned in the composite command does not exist in the devfile"
	selfRefCmdErr := ".*composite command cannot reference itself"
	indirectRefCmdErr := "composite command cannot indirectly reference itself"

	tests := []struct {
		name                 string
		commands             []v1alpha2.Command
		testCompositeCommand string
		wantErr              *string
	}{
		{
			name: "Valid Composite Command",
			commands: append(validExecCommands,
				generateDummyCompositeCommand("command4", []string{"command1", "command2", "command3"}, &v1alpha2.CommandGroup{Kind: buildGroup})),
			testCompositeCommand: "command4",
		},
		{
			name: "Invalid composite command, references non-existent command",
			commands: append(validExecCommands,
				generateDummyCompositeCommand("command4", []string{"command1", "fakecommand", "command3"}, &v1alpha2.CommandGroup{Kind: buildGroup})),
			testCompositeCommand: "command4",
			wantErr:              &missingCmdErr,
		},
		{
			name: "Invalid composite command, references itself",
			commands: append(validExecCommands,
				generateDummyCompositeCommand("command4", []string{"command1", "command4", "command3"}, &v1alpha2.CommandGroup{Kind: buildGroup})),
			testCompositeCommand: "command4",
			wantErr:              &selfRefCmdErr,
		},
		{
			name: "Invalid composite command, indirectly references itself",
			commands: append(validExecCommands,
				generateDummyCompositeCommand("command4", []string{"command5", "command3"}, &v1alpha2.CommandGroup{Kind: buildGroup}),
				generateDummyCompositeCommand("command5", []string{"command1", "command4", "command3"}, &v1alpha2.CommandGroup{Kind: buildGroup})),
			testCompositeCommand: "command4",
			wantErr:              &indirectRefCmdErr,
		},
		{
			name: "Invalid composite command, points to invalid exec command",
			commands: []v1alpha2.Command{
				generateDummyCompositeCommand("command4", []string{"command1", "command2"}, &v1alpha2.CommandGroup{Kind: buildGroup}),
				generateDummyExecCommand("command1", component, &v1alpha2.CommandGroup{Kind: runGroup}),
				generateDummyExecCommand("command2", "some-fake-component", &v1alpha2.CommandGroup{Kind: buildGroup}),
			},