MCPcopy Create free account
hub / github.com/degeneratehyperbola/NEPS / PatchFormatStringFloatToInt

Function PatchFormatStringFloatToInt

shared_lib/imgui/imgui_widgets.cpp:1802–1821  ·  view source on GitHub ↗

FIXME-LEGACY: Prior to 1.61 our DragInt() function internally used floats and because of this the compile-time default value for format was "%.0f". Even though we changed the compile-time default, we expect users to have carried %f around, which would break the display of DragInt() calls. To honor backward compatibility we are rewriting the format string, unless IMGUI_DISABLE_OBSOLETE_FUNCTIONS is

Source from the content-addressed store, hash-verified

1800// Even though we changed the compile-time default, we expect users to have carried %f around, which would break the display of DragInt() calls.
1801// To honor backward compatibility we are rewriting the format string, unless IMGUI_DISABLE_OBSOLETE_FUNCTIONS is enabled. What could possibly go wrong?!
1802static const char* PatchFormatStringFloatToInt(const char* fmt)
1803{
1804 if (fmt[0] == '%' && fmt[1] == '.' && fmt[2] == '0' && fmt[3] == 'f' && fmt[4] == 0) // Fast legacy path for "%.0f" which is expected to be the most common case.
1805 return "%d";
1806 const char* fmt_start = ImParseFormatFindStart(fmt); // Find % (if any, and ignore %%)
1807 const char* fmt_end = ImParseFormatFindEnd(fmt_start); // Find end of format specifier, which itself is an exercise of confidence/recklessness (because snprintf is dependent on libc or user).
1808 if (fmt_end > fmt_start && fmt_end[-1] == 'f')
1809 {
1810#ifndef IMGUI_DISABLE_OBSOLETE_FUNCTIONS
1811 if (fmt_start == fmt && fmt_end[0] == 0)
1812 return "%d";
1813 ImGuiContext& g = *GImGui;
1814 ImFormatString(g.TempBuffer, IM_ARRAYSIZE(g.TempBuffer), "%.*s%%d%s", (int)(fmt_start - fmt), fmt, fmt_end); // Honor leading and trailing decorations, but lose alignment/precision.
1815 return g.TempBuffer;
1816#else
1817 IM_ASSERT(0 && "DragInt(): Invalid format string!"); // Old versions used a default parameter of "%.0f", please replace with e.g. "%d"
1818#endif
1819 }
1820 return fmt;
1821}
1822
1823const ImGuiDataTypeInfo* ImGui::DataTypeGetInfo(ImGuiDataType data_type)
1824{

Callers 3

DragScalarMethod · 0.85
SliderScalarMethod · 0.85
VSliderScalarMethod · 0.85

Calls 3

ImParseFormatFindStartFunction · 0.85
ImParseFormatFindEndFunction · 0.85
ImFormatStringFunction · 0.85

Tested by

no test coverage detected