(t *testing.T)
| 487 | } |
| 488 | |
| 489 | func TestSimpleSignLogoutValidation(t *testing.T) { |
| 490 | e := spcovSetup(t) |
| 491 | slo := e.sp.SloURL.String() |
| 492 | |
| 493 | t.Run("LogoutRequest", func(t *testing.T) { |
| 494 | valid := simpleSignMsg{param: "SAMLRequest", xml: spcovSerialize(t, e.logoutRequest().Element()), relayState: strPtr("rs"), sigAlg: dsig.RSASHA256SignatureMethod, key: e.idpKey} |
| 495 | req, err := e.sp.ValidateLogoutRequest(simpleSignPost(t, slo, valid.values(t))) |
| 496 | assert.NilError(t, err) |
| 497 | assert.Check(t, is.Equal("alice@example.com", req.NameID.Value)) |
| 498 | |
| 499 | v := valid.values(t) |
| 500 | v.Set("RelayState", "other") |
| 501 | _, err = e.sp.ValidateLogoutRequest(simpleSignPost(t, slo, v)) |
| 502 | assert.ErrorContains(t, spcovPrivateErr(t, err), "verification error") |
| 503 | |
| 504 | m := valid |
| 505 | m.key, _ = otherKey(t) |
| 506 | _, err = e.sp.ValidateLogoutRequest(simpleSignPost(t, slo, m.values(t))) |
| 507 | assert.ErrorContains(t, spcovPrivateErr(t, err), "verification error") |
| 508 | |
| 509 | v = valid.values(t) |
| 510 | v.Add("Signature", "x") |
| 511 | _, err = e.sp.ValidateLogoutRequest(simpleSignPost(t, slo, v)) |
| 512 | assert.ErrorContains(t, spcovPrivateErr(t, err), "appears more than once") |
| 513 | |
| 514 | // Unsigned HTTP-POST is still rejected. |
| 515 | _, err = e.sp.ValidateLogoutRequest(simpleSignPost(t, slo, url.Values{"SAMLRequest": {v.Get("SAMLRequest")}})) |
| 516 | assert.ErrorContains(t, spcovPrivateErr(t, err), "signature element not present") |
| 517 | |
| 518 | // The request fields are still validated. |
| 519 | bad := e.logoutRequest() |
| 520 | bad.Destination = "https://other.example.com/slo" |
| 521 | m = valid |
| 522 | m.xml = spcovSerialize(t, bad.Element()) |
| 523 | _, err = e.sp.ValidateLogoutRequest(simpleSignPost(t, slo, m.values(t))) |
| 524 | assert.ErrorContains(t, spcovPrivateErr(t, err), "`Destination` does not match SloURL") |
| 525 | }) |
| 526 | |
| 527 | t.Run("LogoutResponse", func(t *testing.T) { |
| 528 | valid := simpleSignMsg{param: "SAMLResponse", xml: e.unsignedLogoutResponse(t), sigAlg: dsig.RSASHA256SignatureMethod, key: e.idpKey} |
| 529 | assert.NilError(t, e.sp.ValidateLogoutResponseRequest(simpleSignPost(t, slo, valid.values(t)))) |
| 530 | |
| 531 | v := valid.values(t) |
| 532 | v.Set("SAMLResponse", base64.StdEncoding.EncodeToString([]byte(strings.Replace(string(valid.xml), "id-logout-response", "id-other", 1)))) |
| 533 | assert.ErrorContains(t, spcovPrivateErr(t, e.sp.ValidateLogoutResponseRequest(simpleSignPost(t, slo, v))), "verification error") |
| 534 | |
| 535 | v = valid.values(t) |
| 536 | v.Del("SigAlg") |
| 537 | assert.ErrorContains(t, spcovPrivateErr(t, e.sp.ValidateLogoutResponseRequest(simpleSignPost(t, slo, v))), "form must contain both SigAlg and Signature") |
| 538 | |
| 539 | // A valid SimpleSign signature does not excuse an invalid XML one. |
| 540 | signed := e.idpSign(t, e.logoutResponse().Element()) |
| 541 | signed.FindElement("./Issuer").SetText("https://idp.example.com/other") |
| 542 | m := valid |
| 543 | m.xml = spcovSerialize(t, signed) |
| 544 | assert.ErrorContains(t, spcovPrivateErr(t, e.sp.ValidateLogoutResponseRequest(simpleSignPost(t, slo, m.values(t)))), "cannot validate signature on LogoutResponse") |
| 545 | }) |
| 546 | } |
nothing calls this directly
no test coverage detected