(self)
| 2106 | self.TestLint(" memset(buf, 0xcd, 0)", "") |
| 2107 | |
| 2108 | def testRedundantVirtual(self): |
| 2109 | self.TestLint("virtual void F()", "") |
| 2110 | self.TestLint("virtual void F();", "") |
| 2111 | self.TestLint("virtual void F() {}", "") |
| 2112 | |
| 2113 | message_template = ( |
| 2114 | '"%s" is redundant since function is already ' |
| 2115 | 'declared as "%s" [readability/inheritance] [4]' |
| 2116 | ) |
| 2117 | for virt_specifier in ["override", "final"]: |
| 2118 | error_message = message_template % ("virtual", virt_specifier) |
| 2119 | self.TestLint("virtual int F() %s" % virt_specifier, error_message) |
| 2120 | self.TestLint("virtual int F() %s;" % virt_specifier, error_message) |
| 2121 | self.TestLint("virtual int F() %s {" % virt_specifier, error_message) |
| 2122 | |
| 2123 | error_collector = ErrorCollector(self.assertTrue) |
| 2124 | cpplint.ProcessFileData( |
| 2125 | "foo.cc", |
| 2126 | "cc", |
| 2127 | [ |
| 2128 | "// Copyright 2014 Your Company.", |
| 2129 | "virtual void F(int a,", |
| 2130 | " int b) " + virt_specifier + ";", |
| 2131 | "virtual void F(int a,", |
| 2132 | " int b) LOCKS_EXCLUDED(lock) " + virt_specifier + ";", |
| 2133 | "virtual void F(int a,", |
| 2134 | " int b)", |
| 2135 | " LOCKS_EXCLUDED(lock) " + virt_specifier + ";", |
| 2136 | "", |
| 2137 | ], |
| 2138 | error_collector, |
| 2139 | ) |
| 2140 | assert [error_message, error_message, error_message] == error_collector.Results() |
| 2141 | |
| 2142 | error_message = message_template % ("override", "final") |
| 2143 | self.TestLint("int F() override final", error_message) |
| 2144 | self.TestLint("int F() override final;", error_message) |
| 2145 | self.TestLint("int F() override final {}", error_message) |
| 2146 | self.TestLint("int F() final override", error_message) |
| 2147 | self.TestLint("int F() final override;", error_message) |
| 2148 | self.TestLint("int F() final override {}", error_message) |
| 2149 | |
| 2150 | error_collector = ErrorCollector(self.assertTrue) |
| 2151 | cpplint.ProcessFileData( |
| 2152 | "foo.cc", |
| 2153 | "cc", |
| 2154 | [ |
| 2155 | "// Copyright 2014 Your Company.", |
| 2156 | "struct A : virtual B {", |
| 2157 | " ~A() override;};", |
| 2158 | "class C", |
| 2159 | " : public D,", |
| 2160 | " public virtual E {", |
| 2161 | " void Func() override;", |
| 2162 | "}", |
| 2163 | "", |
| 2164 | ], |
| 2165 | error_collector, |
nothing calls this directly
no test coverage detected