Method checkBadBitmaskCheck

lib/checkcondition.cpp:311–349

}

void CheckConditionImpl::checkBadBitmaskCheck()
{
    if (!mSettings.severity.isEnabled(Severity::style) && !mSettings.isPremiumEnabled("badBitmaskCheck"))
        return;

    logChecker("CheckCondition::checkBadBitmaskCheck"); // style

    for (const Token *tok = mTokenizer->tokens(); tok; tok = tok->next()) {
        if (tok->str() == "|" && tok->astOperand1() && tok->astOperand2() && tok->astParent()) {
            const Token* parent = tok->astParent();
            const bool isBoolean = Token::Match(parent, "&&|%oror%") ||
                                   (parent->str() == "?" && parent->astOperand1() == tok) ||
                                   (parent->str() == "=" && parent->astOperand2() == tok && parent->astOperand1() && parent->astOperand1()->variable() && Token::Match(parent->astOperand1()->variable()->typeStartToken(), "bool|_Bool")) ||
                                   (parent->str() == "(" && Token::Match(parent->astOperand1(), "if|while")) ||
                                   (parent->str() == "return" && parent->astOperand1() == tok && inBooleanFunction(tok));

            const bool isTrue = (tok->astOperand1()->hasKnownIntValue() && tok->astOperand1()->getKnownIntValue() != 0) ||
                                (tok->astOperand2()->hasKnownIntValue() && tok->astOperand2()->getKnownIntValue() != 0);

            if (isBoolean && isTrue)
                badBitmaskCheckError(tok);

            // If there are #ifdef in the expression don't warn about redundant | to avoid FP
            const auto& startStop = tok->findExpressionStartEndTokens();
            if (mTokenizer->hasIfdef(startStop.first, startStop.second))
                continue;

            const bool isZero1 = (tok->astOperand1()->hasKnownIntValue() && tok->astOperand1()->getKnownIntValue() == 0);
            const bool isZero2 = (tok->astOperand2()->hasKnownIntValue() && tok->astOperand2()->getKnownIntValue() == 0);
            if (!isZero1 && !isZero2)
                continue;

            if (!tok->isExpandedMacro() &&
                !(isZero1 && isOperandExpanded(tok->astOperand1())) &&
                !(isZero2 && isOperandExpanded(tok->astOperand2())))
                badBitmaskCheckError(tok, /*isNoOp*/ true);
        }
    }
}

void CheckConditionImpl::badBitmaskCheckError(const Token *tok, bool isNoOp)
{