Function TestActivateStaleIncomplete

core/mount/manager/manager_test.go:374–436

(t *testing.T)

}

func TestActivateStaleIncomplete(t *testing.T) {
	td := t.TempDir()
	metadb := filepath.Join(td, "mounts.db")
	targetdir := filepath.Join(td, "m")
	db, err := bolt.Open(metadb, 0600, nil)
	require.NoError(t, err)
	ctx := namespaces.WithNamespace(context.Background(), "test")

	// Simulate a stale incomplete activation by directly writing a bucket
	// without the "active" sub-bucket (as if the process crashed mid-activation).
	// Use mount ID 42 so we can verify the stale target directory gets cleaned up.
	var staleMID uint64 = 42
	err = db.Update(func(tx *bolt.Tx) error {
		v1bkt, err := tx.CreateBucketIfNotExists([]byte("v1"))
		if err != nil {
			return err
		}
		nsbkt, err := v1bkt.CreateBucketIfNotExists([]byte("test"))
		if err != nil {
			return err
		}
		mbkt, err := nsbkt.CreateBucketIfNotExists(bucketKeyMounts)
		if err != nil {
			return err
		}
		// Create the mount bucket but don't add the "active" sub-bucket
		bkt, err := mbkt.CreateBucket([]byte("task1"))
		if err != nil {
			return err
		}
		idb, err := encodeID(staleMID)
		if err != nil {
			return err
		}
		return bkt.Put(bucketKeyID, idb)
	})
	require.NoError(t, err)

	// Create the stale target directory as if the process crashed after
	// mkdir but before the second transaction.
	staleTarget := filepath.Join(targetdir, fmt.Sprintf("%d", staleMID))
	require.NoError(t, os.MkdirAll(staleTarget, 0700))

	mountC := new(atomic.Int32)
	m, err := NewManager(db, targetdir, WithMountHandler("noop", &noopHandler{mounts: mountC}))
	require.NoError(t, err)
	t.Cleanup(func() { assert.NoError(t, m.(io.Closer).Close()) })

	mounts := []mount.Mount{{Type: "noop"}}

	// Activation should succeed by cleaning up the stale entry
	ainfo, err := m.Activate(ctx, "task1", mounts)
	require.NoError(t, err)
	assert.Equal(t, "task1", ainfo.Name)
	assert.Equal(t, 1, len(ainfo.Active))

	// The stale target directory should have been cleaned up
	_, err = os.Stat(staleTarget)