Function Test_ErrorRemovesPartialMessage

x/acpio/acp_conversation_test.go:482–553

(t *testing.T)

}

func Test_ErrorRemovesPartialMessage(t *testing.T) {
	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
	defer cancel()

	mClock := quartz.NewMock(t)
	mock := newMockAgentIO()
	emitter := newMockEmitter()
	// Block the write so we can simulate partial content before error
	started, done := mock.BlockWrite()

	conv := acpio.NewACPConversation(ctx, mock, nil, nil, emitter, mClock)
	conv.Start(ctx)

	// Send blocks, so run in a goroutine
	errCh := make(chan error, 1)
	go func() { errCh <- conv.Send(screentracker.MessagePartText{Content: "test"}) }()

	// Wait for write to start
	<-started

	// Should have user message + placeholder agent message
	messages := conv.Messages()
	require.Len(t, messages, 2)
	assert.Equal(t, screentracker.ConversationRoleUser, messages[0].Role)
	assert.Equal(t, screentracker.ConversationRoleAgent, messages[1].Role)

	// Simulate the agent streaming partial content before the error
	mock.SimulateChunks("partial ", "response ", "content")

	// Verify partial content is in the agent message
	messages = conv.Messages()
	require.Len(t, messages, 2)
	assert.Equal(t, "partial response content", messages[1].Message)

	// Now configure the mock to return an error and unblock
	mock.mu.Lock()
	mock.writeErr = assert.AnError
	mock.mu.Unlock()
	close(done)

	// Send should return the error
	require.ErrorIs(t, <-errCh, assert.AnError)

	// The partial agent message should be removed on error.
	// Only the user message should remain.
	messages = conv.Messages()
	require.Len(t, messages, 1, "partial agent message should be removed on error")
	assert.Equal(t, screentracker.ConversationRoleUser, messages[0].Role)
	assert.Equal(t, "test", messages[0].Message)

	// First exchange allocated IDs 0 (user) and 1 (agent, now removed).
	assert.Equal(t, 0, messages[0].Id)

	// Send a second message — IDs must not reuse the removed agent message's ID (1).
	mock.mu.Lock()
	mock.writeErr = nil
	mock.mu.Unlock()
	started2, done2 := mock.BlockWrite()