Function uploadAsset

pkg/cmd/release/shared/upload.go:158–209

(ctx context.Context, httpClient *http.Client, uploadURL safeurl.SafeURL, asset AssetForUpload)

}

func uploadAsset(ctx context.Context, httpClient *http.Client, uploadURL safeurl.SafeURL, asset AssetForUpload) (*ReleaseAsset, error) {
	u, err := url.Parse(uploadURL.String())
	if err != nil {
		return nil, err
	}
	params := u.Query()
	params.Set("name", asset.Name)
	params.Set("label", asset.Label)
	u.RawQuery = params.Encode()

	// Since u is derived from uploadURL, an already-trusted safeurl.SafeURL, the resulting URL is safe to declare as such.
	safeURL := safeurl.NewImmutableSafeURL(u.String())

	f, err := asset.Open()
	if err != nil {
		return nil, err
	}
	defer f.Close()

	req, err := http.NewRequestWithContext(ctx, "POST", safeURL.String(), f)
	if err != nil {
		return nil, err
	}
	req.ContentLength = asset.Size
	req.Header.Set("Content-Type", asset.MIMEType)
	req.GetBody = asset.Open

	// DoRequest rather than Request because ContentLength and GetBody are set on the request
	// itself, and neither can be expressed as a header. The upload URL is supplied by the API
	// and points at the uploads host, so there is no endpoint resolution to delegate here.
	// TODO(api-client-rollout)
	// This line of code is part of a mechanical roll out of the api client.
	// As a follow up, consider whether the api client can be injected to this call site, rather than constructed
	resp, err := api.NewClientFromHTTP(httpClient).DoRequest(req)
	if err != nil {
		// Only transport failures are retryable as network errors. A response that arrived and
		// carried a failing status is reported as is, so shouldRetry can judge it by status.
		if _, ok := errors.AsType[api.HTTPError](err); ok {
			return nil, err
		}
		return nil, errNetwork{err}
	}
	defer resp.Body.Close()

	var newAsset ReleaseAsset
	dec := json.NewDecoder(resp.Body)
	if err := dec.Decode(&newAsset); err != nil {
		return nil, err
	}

	return &newAsset, nil
}

func deleteAsset(ctx context.Context, httpClient *http.Client, hostname string, assetURL safeurl.SafeURL) error {
	// The asset URL is supplied by the API, so it is absolute and requested as given.