Function TestFetchCommitSHA

pkg/cmd/extension/http_test.go:240–276

TestFetchCommitSHA covers the two things that kept this site on the raw client: the custom Accept media type that makes the API answer with a bare SHA, and the 422 sentinel.

(t *testing.T)

// TestFetchCommitSHA covers the two things that kept this site on the raw client: the custom
// Accept media type that makes the API answer with a bare SHA, and the 422 sentinel.
func TestFetchCommitSHA(t *testing.T) {
	repo := ghrepo.New("OWNER", "REPO")

	t.Run("sends the sha media type and returns the bare body", func(t *testing.T) {
		reg := &httpmock.Registry{}
		defer reg.Verify(t)

		reg.Register(
			func(req *http.Request) bool {
				return req.URL.Path == "/repos/OWNER/REPO/commits/main" &&
					req.Header.Get("Accept") == "application/vnd.github.v3.sha"
			},
			httpmock.StatusStringResponse(http.StatusOK, "0123456789abcdef"),
		)

		sha, err := fetchCommitSHA(&http.Client{Transport: reg}, repo, "main")

		require.NoError(t, err)
		assert.Equal(t, "0123456789abcdef", sha)
	})

	t.Run("unprocessable entity means the commit was not found", func(t *testing.T) {
		client := extensionHTTPClient(t, "repos/OWNER/REPO/commits/nope", http.StatusUnprocessableEntity, `{"message":"No commit found"}`)

		_, err := fetchCommitSHA(client, repo, "nope")

		require.ErrorIs(t, err, commitNotFoundErr)
	})

	t.Run("other errors are reported", func(t *testing.T) {
		client := extensionHTTPClient(t, "repos/OWNER/REPO/commits/main", http.StatusInternalServerError, `{"message":"Internal Server Error"}`)

		_, err := fetchCommitSHA(client, repo, "main")

		requireExtensionHTTPError(t, err, http.StatusInternalServerError)
	})
}

// TestDownloadAsset pins the octet-stream media type, without which the API returns asset
// metadata as JSON rather than the binary itself.