Function TestDownloadAsset

pkg/cmd/extension/http_test.go:280–317

TestDownloadAsset pins the octet-stream media type, without which the API returns asset metadata as JSON rather than the binary itself.

(t *testing.T)

// TestDownloadAsset pins the octet-stream media type, without which the API returns asset
// metadata as JSON rather than the binary itself.
func TestDownloadAsset(t *testing.T) {
	t.Run("sends the octet-stream media type and writes the body", func(t *testing.T) {
		reg := &httpmock.Registry{}
		defer reg.Verify(t)

		reg.Register(
			func(req *http.Request) bool {
				return req.URL.String() == "https://example.com/release/cool" &&
					req.Header.Get("Accept") == "application/octet-stream"
			},
			httpmock.StatusStringResponse(http.StatusOK, "BINARY"),
		)

		destPath := filepath.Join(t.TempDir(), "gh-cool")
		err := downloadAsset(&http.Client{Transport: reg}, "github.com", safeurl.NewImmutableSafeURL("https://example.com/release/cool"), destPath)

		require.NoError(t, err)
		contents, err := os.ReadFile(destPath)
		require.NoError(t, err)
		assert.Equal(t, "BINARY", string(contents))
	})

	t.Run("errors are reported", func(t *testing.T) {
		reg := &httpmock.Registry{}
		defer reg.Verify(t)

		reg.Register(
			httpmock.REST(http.MethodGet, "release/cool"),
			httpmock.StatusStringResponse(http.StatusNotFound, `{"message":"Not Found"}`),
		)

		destPath := filepath.Join(t.TempDir(), "gh-cool")
		err := downloadAsset(&http.Client{Transport: reg}, "github.com", safeurl.NewImmutableSafeURL("https://example.com/release/cool"), destPath)

		requireExtensionHTTPError(t, err, http.StatusNotFound)
		assert.NoFileExists(t, destPath)
	})
}