Function TestRequestDoesNotDecodeSuccessfulResponses

api/request_test.go:141–167

REST treats 204 and 205 specially and decodes every other 2xx as JSON. Request must do neither, so that bodiless successes and non-JSON successes both work.

(t *testing.T)

// REST treats 204 and 205 specially and decodes every other 2xx as JSON. Request must do neither,
// so that bodiless successes and non-JSON successes both work.
func TestRequestDoesNotDecodeSuccessfulResponses(t *testing.T) {
	tests := []struct {
		name       string
		statusCode int
		body       string
	}{
		{name: "bodiless 200, as returned by HEAD", statusCode: 200, body: ""},
		{name: "no content", statusCode: 204, body: ""},
		{name: "non-JSON body", statusCode: 200, body: "d3f9c4a"},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			reg := &httpmock.Registry{}
			defer reg.Verify(t)
			client := newTestClient(reg)

			reg.Register(httpmock.MatchAny, httpmock.StatusStringResponse(tt.statusCode, tt.body))

			resp, err := client.Request("github.com", http.MethodGet, "repos/OWNER/REPO", nil)
			require.NoError(t, err)
			defer resp.Body.Close()

			assert.Equal(t, tt.statusCode, resp.StatusCode)
		})
	}
}

func TestRequestError(t *testing.T) {
	reg := &httpmock.Registry{}