Method executeOpenFile

src/engine/MacroChoiceEngine.ts:823–867

(command: IOpenFileCommand)

	}

	private async executeOpenFile(command: IOpenFileCommand) {
		try {
			const formatter = new CompleteFormatter(
				this.app,
				getQuickAddInstance(),
				this.choiceExecutor
			);

			const resolvedPath = await formatter.formatFileName(command.filePath, "");
			const normalizedPath = resolvedPath.replace(/\\/g, "/");

			// Validate path segments to prevent traversal attacks. A substring check
			// would wrongly reject legitimate filenames that merely contain ".." (e.g.
			// 'log..2024.md') or "//"; only a literal '..' path segment or an empty
			// segment (from '//') is an actual traversal/malformed path.
			const segments = normalizedPath.split("/");
			const hasTraversal = segments.some(
				(segment, index) =>
					segment === ".." ||
					// An empty segment is a doubled slash; the leading slash of an
					// absolute path is allowed (index 0), as is a single trailing slash.
					(segment === "" && index !== 0 && index !== segments.length - 1)
			);
			if (hasTraversal) {
				log.logError(`OpenFile: Path traversal not allowed in '${normalizedPath}'`);
				return;
			}

			const file = this.app.vault.getAbstractFileByPath(normalizedPath);

			if (!file || !(file instanceof TFile)) {
				log.logError(`OpenFile: '${normalizedPath}' does not exist or is not a file`);
				return;
			}

			const openOptions = buildOpenFileOptions(command);

			await openFile(this.app, file, {
				...openOptions,
				originLeaf: this.originLeaf,
			});
		} catch (error) {
			log.logError(`OpenFile: Failed to open file '${command.filePath}': ${error.message}`);
		}
	}
}