(t *testing.T)
| 102 | } |
| 103 | |
| 104 | func TestIsMutableAccuSafe(t *testing.T) { |
| 105 | tests := []struct { |
| 106 | expr string |
| 107 | safe bool |
| 108 | }{ |
| 109 | // Standard macros which build lists and maps are optimized. |
| 110 | {expr: `[1, 2].map(x, x + 1)`, safe: true}, |
| 111 | {expr: `[1, 2].map(x, x > 1, x + 1)`, safe: true}, |
| 112 | {expr: `[1, 2].filter(x, x > 1)`, safe: true}, |
| 113 | {expr: `[[1], [2]].map(x, x.map(y, y + 1))`, safe: true}, |
| 114 | {expr: `compre(i, a, [1], [], true, a + [i], a)`, safe: true}, |
| 115 | {expr: `compre(i, a, [1], [], true, i > 0 ? a + [i] : a, a)`, safe: true}, |
| 116 | {expr: `compre(i, a, [1], [], true, a + [compre(j, a, [2], [], true, a + [j], a)], a)`, safe: true}, |
| 117 | // Map insertion requires a two-variable comprehension. |
| 118 | {expr: `compre2(k, v, a, {1: 2}, {}, true, insert(a, k, v), a)`, safe: true}, |
| 119 | {expr: `compre2(k, v, a, {1: 2}, {}, true, insert(a, {k: v}), a)`, safe: true}, |
| 120 | {expr: `compre2(k, v, a, {1: 2}, {}, true, k > 0 ? insert(a, k, v) : a, a)`, safe: true}, |
| 121 | {expr: `compre(i, a, [1], {}, true, insert(a, i, i), a)`, safe: false}, |
| 122 | |
| 123 | // Shapes which cel-cpp accepts without inspecting the accumulator's other uses. These |
| 124 | // match cel-cpp's IsOptimizableListAppend / IsOptimizableMapInsert behavior. |
| 125 | {expr: `compre(i, a, [1], [], a.size() < 2, a + [i], a)`, safe: true}, |
| 126 | {expr: `compre(i, a, [1], [], true, a + [a], a)`, safe: true}, |
| 127 | {expr: `compre(i, a, [1], [], true, a.size() > 0 ? a + [i] : a, a)`, safe: true}, |
| 128 | {expr: `compre(i, a, [1], [], true, i > 0 ? a + [i] : [a], a)`, safe: true}, |
| 129 | {expr: `compre2(k, v, a, {1: 2}, {}, true, insert(a, k, a), a)`, safe: true}, |
| 130 | |
| 131 | // cel.bind style comprehensions where the result is not the bare accumulator. |
| 132 | {expr: `bind(x, [], [x + [1], x + [2]])`, safe: false}, |
| 133 | {expr: `bind(x, [], x + [1])`, safe: false}, |
| 134 | {expr: `bind(x, [], bind(y, x + [1], x))`, safe: false}, |
| 135 | {expr: `bind(x, {}, [x, x])`, safe: false}, |
| 136 | {expr: `compre(i, a, [1], [], true, a + [i], [a, a])`, safe: false}, |
| 137 | {expr: `compre(i, a, [1], [], true, a + [i], a.size())`, safe: false}, |
| 138 | {expr: `compre(i, a, [1], [], true, a + [i], 1)`, safe: false}, |
| 139 | // Accumulator initializer must be an empty list or map literal. |
| 140 | {expr: `compre(i, a, [1], [0], true, a + [i], a)`, safe: false}, |
| 141 | {expr: `compre(i, a, [1], dyn([]), true, a + [i], a)`, safe: false}, |
| 142 | {expr: `compre2(k, v, a, {1: 2}, {'x': 1}, true, insert(a, k, v), a)`, safe: false}, |
| 143 | // Loop step must be `accu + [elem]`, optionally as the true branch of a ternary. |
| 144 | {expr: `compre(i, a, [1], [], true, [i], a)`, safe: false}, |
| 145 | {expr: `compre(i, a, [1], [], true, a + a, a)`, safe: false}, |
| 146 | {expr: `compre(i, a, [1], [], true, a + [i, i], a)`, safe: false}, |
| 147 | {expr: `compre(i, a, [1], [], true, [i] + a, a)`, safe: false}, |
| 148 | {expr: `compre(i, a, [1], [], true, (a + [i]) + [i], a)`, safe: false}, |
| 149 | {expr: `compre(i, a, [1], [], true, {'k': a}.k + [i], a)`, safe: false}, |
| 150 | {expr: `compre(i, a, [1], [], true, i > 0 ? a : a + [i], a)`, safe: false}, |
| 151 | {expr: `compre(i, a, [1], [], true, bind(y, a, y + [i]), a)`, safe: false}, |
| 152 | {expr: `compre(i, a, [1], [], true, compre(j, b, a, [], true, b + [j], b), a)`, safe: false}, |
| 153 | // Empty or shadowed accumulator names disable mutation. |
| 154 | {expr: `compre(a, a, [1], [], true, a + [1], a)`, safe: false}, |
| 155 | {expr: `compre2(k, a, a, {1: 2}, {}, true, insert(a, k, k), a)`, safe: false}, |
| 156 | // Accumulator names which may be written in CEL source disable mutation, even when the |
| 157 | // comprehension otherwise matches the cel-cpp shape. |
| 158 | {expr: `compre(i, acc, [1], [], true, acc + [i], acc)`, safe: false}, |
| 159 | {expr: `compre(i, __result__, [1], [], true, __result__ + [i], __result__)`, safe: false}, |
| 160 | {expr: `compre2(k, v, acc, {1: 2}, {}, true, insert(acc, k, v), acc)`, safe: false}, |
| 161 | } |
nothing calls this directly
no test coverage detected