Function create_intent

atomic-cli/src/commands/intent/new.rs:134–211

The core create logic, factored out so it can be unit-tested against an explicit [`Repository`] (the [`Command::run`] impl resolves the repo from the cwd and delegates here). Returns the created intent alongside its resolved classification `kind` (for display). `--review` wins over `--kind`: when `review_target` is `Some`, the intent is a `review` regardless of `kind`. The CLI parser already reje

(
    repo: &Repository,
    title: &str,
    kind: &str,
    review_target: Option<&str>,
)

/// a `review` regardless of `kind`. The CLI parser already rejects supplying
/// both explicitly (`conflicts_with`), so this only encodes the precedence.
fn create_intent(
    repo: &Repository,
    title: &str,
    kind: &str,
    review_target: Option<&str>,
) -> CliResult<(IntentCreateResult, String)> {
    // Resolve the effective kind + which scaffold to emit.
    let (kind, scaffold) = if let Some(target) = review_target {
        // Emit the canonical URN even when the caller named the target
        // bare. A bare ULID reads fine but projects an edge that nothing
        // can match, so the review silently fails to cover its target.
        let target = if target.trim().starts_with("urn:") {
            target.trim().to_string()
        } else {
            format!("urn:atomic:intent:{}", target.trim())
        };
        (
            "review".to_string(),
            REVIEW_SCAFFOLD.to_string().replace("{target}", &target),
        )
    } else {
        if !is_known_intent_kind(kind) {
            return Err(CliError::InvalidArgument {
                message: format!(
                    "unknown intent kind '{}' (expected one of {:?})",
                    kind, INTENT_KIND
                ),
            });
        }
        (kind.to_string(), FEATURE_SCAFFOLD.to_string())
    };

    // A non-default kind is threaded into `IntentCreateOptions` so create writes
    // the `kind:` frontmatter key; the default `feature` stays `None` to keep an
    // ordinary intent's frontmatter (and canonical hash) byte-for-byte unchanged.
    let kind_opt = if kind == "feature" {
        None
    } else {
        Some(kind.clone())
    };

    // Create through the EXISTING vault write path so the intent enters redb
    // normally and joins the merkle exactly as `atomic vault intent create` does
    // — we do NOT invent a new redb write.
    let created = repo
        .vault_intent_create(IntentCreateOptions {
            title: title.to_string(),
            priority: None,
            assignee: None,
            labels: Vec::new(),
            session_id: None,
            turn_id: None,
            kind: kind_opt,
        })
        .map_err(CliError::Repository)?;

    // Overwrite the (legacy positional) scaffold body with the directive
    // scaffold, again through the existing update path. `force` is set because