Method SubstituteArg

be/src/gutil/strings/substitute.h:76–77

We must explicitly overload char* so that the compiler doesn't try to cast it to bool to construct a DynamicSubstituteArg. Might as well overload const string& as well, since this allows us to avoid a temporary object.

  // overload const string& as well, since this allows us to avoid a temporary
  // object.
  inline SubstituteArg(const char* value)  // NOLINT(runtime/explicit)
    : text_(value), size_(value == NULL ? 0 : strlen(text_)) {}
  inline SubstituteArg(const string& value)  // NOLINT(runtime/explicit)
    : text_(value.data()), size_(value.size()) {}
  inline SubstituteArg(const StringPiece& value)  // NOLINT(runtime/explicit)