Function TestSelectStarRule

pkg/advisor/optimizer_test.go:49–83

--------------------------------------------------------------------------- OPT-001: SELECT * Detection ---------------------------------------------------------------------------

(t *testing.T)

// ---------------------------------------------------------------------------

func TestSelectStarRule(t *testing.T) {
	opt := New()

	tests := []struct {
		name    string
		sql     string
		wantHit bool
	}{
		{
			name:    "SELECT * triggers suggestion",
			sql:     "SELECT * FROM users",
			wantHit: true,
		},
		{
			name:    "Named columns do not trigger",
			sql:     "SELECT id, name FROM users",
			wantHit: false,
		},
		{
			name:    "COUNT(*) does not trigger",
			sql:     "SELECT COUNT(*) FROM users",
			wantHit: false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			result := mustAnalyze(t, opt, tt.sql)
			got := hasSuggestion(result, "OPT-001")
			if got != tt.wantHit {
				t.Errorf("hasSuggestion(OPT-001) = %v, want %v for SQL %q", got, tt.wantHit, tt.sql)
			}
		})
	}
}

// ---------------------------------------------------------------------------
// OPT-002: Missing WHERE Clause