Function TestMissingWhereRule

pkg/advisor/optimizer_test.go:89–141

--------------------------------------------------------------------------- OPT-002: Missing WHERE Clause ---------------------------------------------------------------------------

(t *testing.T)

// ---------------------------------------------------------------------------

func TestMissingWhereRule(t *testing.T) {
	opt := New()

	tests := []struct {
		name    string
		sql     string
		wantHit bool
	}{
		{
			name:    "UPDATE without WHERE triggers",
			sql:     "UPDATE users SET active = true",
			wantHit: true,
		},
		{
			name:    "UPDATE with WHERE does not trigger",
			sql:     "UPDATE users SET active = true WHERE id = 1",
			wantHit: false,
		},
		{
			name:    "DELETE without WHERE triggers",
			sql:     "DELETE FROM orders",
			wantHit: true,
		},
		{
			name:    "DELETE with WHERE does not trigger",
			sql:     "DELETE FROM orders WHERE status = 'expired'",
			wantHit: false,
		},
		{
			name:    "SELECT without WHERE does not trigger (rule only applies to UPDATE/DELETE)",
			sql:     "SELECT * FROM users",
			wantHit: false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			result := mustAnalyze(t, opt, tt.sql)
			got := hasSuggestion(result, "OPT-002")
			if got != tt.wantHit {
				t.Errorf("hasSuggestion(OPT-002) = %v, want %v for SQL %q", got, tt.wantHit, tt.sql)
			}
			// Verify severity is error for dangerous operations
			if tt.wantHit {
				for _, s := range result.Suggestions {
					if s.RuleID == "OPT-002" && s.Severity != SeverityError {
						t.Errorf("expected severity %q for OPT-002, got %q", SeverityError, s.Severity)
					}
				}
			}
		})
	}
}

// ---------------------------------------------------------------------------
// OPT-003: Cartesian Product Detection