Function TestCleanQueries

pkg/advisor/optimizer_test.go:695–736

--------------------------------------------------------------------------- Clean query tests (no suggestions expected) ---------------------------------------------------------------------------

(t *testing.T)

// ---------------------------------------------------------------------------

func TestCleanQueries(t *testing.T) {
	opt := New()

	cleanQueries := []struct {
		name string
		sql  string
	}{
		{
			name: "simple SELECT with named columns",
			sql:  "SELECT id, name, email FROM users WHERE active = true",
		},
		{
			name: "JOIN with WHERE and named columns",
			sql:  "SELECT u.id, o.total FROM users u JOIN orders o ON u.id = o.user_id WHERE o.status = 'completed'",
		},
		{
			name: "UPDATE with WHERE",
			sql:  "UPDATE users SET active = false WHERE last_login < '2024-01-01'",
		},
		{
			name: "DELETE with WHERE",
			sql:  "DELETE FROM sessions WHERE expired_at < NOW()",
		},
		{
			name: "INSERT statement",
			sql:  "INSERT INTO users (name, email) VALUES ('John', 'john@test.com')",
		},
	}

	for _, tt := range cleanQueries {
		t.Run(tt.name, func(t *testing.T) {
			result := mustAnalyze(t, opt, tt.sql)
			// A clean query might still have some info-level suggestions;
			// the important thing is no error or warning suggestions.
			for _, s := range result.Suggestions {
				if s.Severity == SeverityError {
					t.Errorf("clean query %q produced error suggestion: %s - %s", tt.sql, s.RuleID, s.Message)
				}
			}
		})
	}
}

// ---------------------------------------------------------------------------
// AnalyzeSQL convenience method