Function TestCartesianProductRule

pkg/advisor/optimizer_test.go:147–176

--------------------------------------------------------------------------- OPT-003: Cartesian Product Detection ---------------------------------------------------------------------------

(t *testing.T)

// ---------------------------------------------------------------------------

func TestCartesianProductRule(t *testing.T) {
	opt := New()

	tests := []struct {
		name    string
		sql     string
		wantHit bool
	}{
		{
			name:    "Single table does not trigger",
			sql:     "SELECT id FROM users",
			wantHit: false,
		},
		{
			name:    "Explicit JOIN does not trigger",
			sql:     "SELECT u.id, o.total FROM users u JOIN orders o ON u.id = o.user_id",
			wantHit: false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			result := mustAnalyze(t, opt, tt.sql)
			got := hasSuggestion(result, "OPT-003")
			if got != tt.wantHit {
				t.Errorf("hasSuggestion(OPT-003) = %v, want %v for SQL %q", got, tt.wantHit, tt.sql)
			}
		})
	}
}

func TestCartesianProductRuleDirect(t *testing.T) {
	// Test with directly constructed AST to ensure rule logic works