Function section5

tests/rigctld_test.cpp:743–1068

// ═════════════════════════════════════════════════════════════════════════════

void section5(RigctlClient& c, Runner& r, qint64 origFreq)
{
    r.section(QStringLiteral("Section 5 — Split VFO"));
    const qint64 splitTxFreq = origFreq + 1000;

    // ── DAX-assign settle guard ──────────────────────────────────────────────
    // Closing a TX slice we created on demand frees its SliceModel. If a deferred
    // DAX-channel-assign timer is still pending — it's armed on sliceAdded when a
    // DAX/TCI audio client is active, e.g. after WSJT-X has been used on this radio
    // — it fires on the freed slice and crashes ASDR. A real client never creates
    // and removes a split slice this fast; only this test does. So settle before
    // every on-demand split teardown to let that timer fire on the LIVE slice
    // first. (The underlying DAX-timer UAF is a separate, app-side issue.)
    constexpr int kDaxSettleMs = 700;
    const QString kSplitOff = QStringLiteral("\\set_split_vfo 0 VFOA");
    auto disableSplitSettled = [&]() {
        QThread::msleep(kDaxSettleMs);
        return c.send(kSplitOff);
    };

    // Poll get_split_vfo until Split == want (or timeout); return the final value.
    // Replaces the do/while poll loop that was hand-rolled at every split check.
    auto waitForSplit = [&](QLatin1String want, int timeoutMs) -> QString {
        QString s;
        QElapsedTimer t; t.start();
        do {
            s = c.field(c.send(QStringLiteral("\\get_split_vfo")), QStringLiteral("Split"));
            if (s == want || t.elapsed() >= timeoutMs) break;
            QThread::msleep(150);
        } while (true);
        return s;
    };
    // Settle-disable split and confirm it reached the off state — the "known-off
    // baseline" precondition several subtests need.
    auto resetSplitOff = [&]() {
        disableSplitSettled();
        return waitForSplit(QLatin1String("0"), 2000) == QLatin1String("0");
    };

    // 5.1  baseline split state
    QStringList lines = c.send(QStringLiteral("\\get_split_vfo"));
    const QString splitVal = c.field(lines, QStringLiteral("Split"));
    const QString txVfo    = c.field(lines, QStringLiteral("TX VFO"));
    r.check(QStringLiteral("5.1  get_split_vfo returns Split (0/1) and TX VFO fields"),
            c.ok(lines)
                && (splitVal == QLatin1String("0") || splitVal == QLatin1String("1"))
                && (txVfo == QLatin1String("VFOA") || txVfo == QLatin1String("VFOB")),
            QStringLiteral("Split=%1 TX VFO=%2").arg(splitVal, txVfo));

    // 5.2  enable split
    lines = c.send(QStringLiteral("\\set_split_vfo 1 VFOB"));
    r.check(QStringLiteral("5.2  set_split_vfo 1 VFOB returns RPRT 0"), c.ok(lines));

    // 5.3  poll until split is confirmed active (creating a new slice takes variable time)
    const QString splitOn = waitForSplit(QLatin1String("1"), 5000);
    r.check(QStringLiteral("5.3  get_split_vfo reports Split: 1  [needs 2 slices in GUI]"),
            splitOn == QLatin1String("1"),
            QStringLiteral("Split=%1 — open a second slice in AetherSDR if this fails")