Method execute

src/tools/codegraph/quality.ts:176–317

(args: z.infer<typeof SuggestImprovementsArgs>, ctx: ToolContext)

  argsSchema = SuggestImprovementsArgs;

  async execute(args: z.infer<typeof SuggestImprovementsArgs>, ctx: ToolContext): Promise<ToolResult> {
    const root = args.path ? path.join(ctx.cwd, args.path) : ctx.cwd;
    const maxFiles = args.max_files ?? 3000;
    const largeFile = args.large_file_threshold ?? 500;
    const longFn = args.long_function_threshold ?? 50;

    const files = await walkSource(root, maxFiles);
    const suggestions: Suggestion[] = [];
    let todoCount = 0;

    for (const f of files) {
      // 1. Large files
      if (f.lines >= largeFile) {
        suggestions.push({
          severity: f.lines >= largeFile * 2 ? 'high' : 'medium',
          kind: 'large_file',
          file: f.rel,
          detail: `${f.lines} lines — consider splitting into focused modules.`,
        });
      }

      // 2. Long functions (heuristic: function declaration + naive matching brace count)
      const lines = f.content.split('\n');
      const fnStart = /^(\s*)(?:export\s+)?(?:async\s+)?(?:function\s+\w+|const\s+\w+\s*=\s*(?:async\s*)?\(|\w+\s*\([^)]*\)\s*\{|def\s+\w+|class\s+\w+)/;
      for (let i = 0; i < lines.length; i++) {
        const line = lines[i]!;
        const m = fnStart.exec(line);
        if (m && line.includes('{')) {
          const baseIndent = m[1]!.length;
          // find matching closing brace via indent + 0-depth heuristic
          let depth = 0;
          for (const ch of line) { if (ch === '{') depth++; if (ch === '}') depth--; }
          let end = i;
          for (let j = i + 1; j < lines.length && j < i + 400; j++) {
            for (const ch of lines[j]!) { if (ch === '{') depth++; if (ch === '}') depth--; }
            if (depth <= 0) { end = j; break; }
          }
          const fnLen = end - i + 1;
          if (fnLen >= longFn) {
            const namePart = (line.match(/\b(function|const|class|def)\s+(\w+)/) || [, , line.slice(0, 80)])[2];
            suggestions.push({
              severity: fnLen >= longFn * 2 ? 'high' : 'medium',
              kind: 'long_function',
              file: f.rel,
              line: i + 1,
              detail: `${namePart} — ${fnLen} lines — consider extracting helpers.`,
            });
            // jump past it to avoid double-counting nested
            i = end;
          }
        }
      }

      // 3. Deep nesting (heuristic: any line with 6+ levels of indent)
      for (let i = 0; i < lines.length; i++) {
        const line = lines[i]!;
        if (line.trim() === '') continue;
        const leading = line.match(/^( +|\t+)/);