Method executeRequest

internal/mcp/dispatch_http.go:475–501

executeRequest builds + serves + packages a single HTTP request against the wrapped handler. Pulled out of Dispatch so the special-case methods (dispatchItemUpdate, future RMW commands) can reuse the same auth-context + recorder + response-shaping path. Scope enforcement lives in buildAuthedRequest

(
	ctx context.Context,
	cmdKey string,
	user *models.User,
	method, urlPath string,
	body []byte,
)

// through this method. Codex review #369 round 2 caught the leak that
// motivated centralizing the check.
func (d *HTTPHandlerDispatcher) executeRequest(
	ctx context.Context,
	cmdKey string,
	user *models.User,
	method, urlPath string,
	body []byte,
) (*mcp.CallToolResult, error) {
	req, err := d.buildAuthedRequest(ctx, method, urlPath, body, user)
	if err != nil {
		return buildRequestErrorResult(cmdKey, err), nil
	}

	rec := httptest.NewRecorder()
	d.Handler.ServeHTTP(rec, req)
	// Use req.Context() (NOT the outer ctx) so the workspace lister
	// sees everything buildHTTPRequest + d.Apply attached:
	// WithCurrentUser, WithAPITokenAuth, and any TokenAllowedWorkspaces
	// the dispatcher's Apply hook layered on. Tests that drive
	// executeRequest with context.Background() + a UserResolver get
	// the user via req.Context(), not via the outer ctx — without
	// this fix the lister would silently return empty hints in
	// those test paths and (more critically) in any production
	// dispatcher that attaches token state via Apply rather than
	// inheriting from the inbound request's ctx. Codex review #379
	// round 1.
	return packageHTTPResponse(req.Context(), cmdKey, rec.Result(), d.Lister)
}

// buildRequestErrorResult maps a buildAuthedRequest failure onto the
// structured error envelope. Extracted from executeRequest (BUG-2305,