Function TestClassifyHTTPStatus

internal/mcp/errors_test.go:158–216

TestClassifyHTTPStatus covers the HTTP status → ErrorCode mapping. Each documented status maps to the expected code; unmapped statuses fall through to server_error.

(t *testing.T)

// Each documented status maps to the expected code; unmapped statuses
// fall through to server_error.
func TestClassifyHTTPStatus(t *testing.T) {
	cases := []struct {
		name     string
		status   int
		body     string
		wantCode ErrorCode
	}{
		{"401_unauthorized", http.StatusUnauthorized, "token invalid", ErrAuthRequired},
		{"403_forbidden", http.StatusForbidden, "role insufficient", ErrPermissionDenied},
		{"404_item", http.StatusNotFound, "item TASK-99 not found", ErrItemNotFound},
		{"404_workspace", http.StatusNotFound, "workspace foo not visible", ErrUnknownWorkspace},
		{"409_conflict", http.StatusConflict, "version mismatch", ErrConflict},
		{"422_validation", http.StatusUnprocessableEntity, "title required", ErrValidationFailed},
		{"400_validation", http.StatusBadRequest, "bad input", ErrValidationFailed},
		// TASK-1078: 5xx now maps to upstream_error (distinct from
		// server_error, which is reserved for dispatcher internal
		// failures + un-mapped 4xx). Pre-fix every 5xx collapsed to
		// ErrServerError; the new code lets agents distinguish
		// "backend hiccup, retry" from "dispatcher bug, escalate."
		{"500_upstream", http.StatusInternalServerError, "boom", ErrUpstreamError},
		{"503_upstream", http.StatusServiceUnavailable, "down", ErrUpstreamError},
		// BUG-1430: 429 is now a first-class ErrRateLimited code,
		// distinct from the generic ErrServerError "other 4xx" bucket
		// it landed in pre-fix. Agents implementing backoff key off
		// the code without parsing free-form text.
		{"429_rate_limited", http.StatusTooManyRequests, "rate_limited", ErrRateLimited},
		{"418_other", http.StatusTeapot, "weird", ErrServerError},
	}
	for _, tc := range cases {
		t.Run(tc.name, func(t *testing.T) {
			res := classifyHTTPStatus(context.Background(),
				"pad item list", tc.status, []byte(tc.body), nil)
			if !res.IsError {
				t.Errorf("expected IsError")
			}
			env := decodeEnvelope(t, res)
			if env.Error.Code != tc.wantCode {
				t.Errorf("Code = %q, want %q", env.Error.Code, tc.wantCode)
			}
			// Body fragment preservation contract changed in TASK-1077:
			// pre-fix the raw body was always copied into Hint, which
			// would leak unstructured upstream output (Codex review #387
			// round 1). Post-fix only structured-envelope-shaped bodies
			// have their inner message lifted; unstructured bodies are
			// dropped to avoid leaking tokens / debug dumps.
			//
			// Each test case above passes a bare string body — those
			// hit the safe-fallback path and don't appear in the
			// envelope. The unknown_workspace branch can also legitimately
			// emit an empty Hint (no upstream message AND no extractable
			// slug AND no lister wired). This test asserts the code
			// mapping; body preservation specifically is tested in
			// TestExtractUpstreamMessage with structured input, and hint
			// shape per code is tested in
			// TestClassifyHTTPStatus_HintsAreActionable.
			_ = env.Error.Hint
		})
	}