Class TestGlobalDefaults

tests/unit/test_false_positive_reductions.py:313–345

# ===========================================================================

class TestGlobalDefaults:
    def test_global_exclusion_suppresses_any_rule_in_tests(self):
        """
        The [defaults] exclude_file_patterns applies to ALL rules without
        needing to repeat exclude_file_pattern on each rule individually.

        PY305 (exec) has NO per-rule exclude_file_pattern, yet it must be
        suppressed in test files because [defaults] excludes *tests*.
        """
        code = "exec(user_input)\n"
        # In tests/ dir → global default should suppress PY305
        assert findings_for_rule(code, "PY305", in_tests_dir=True) == [], \
            "PY305 must be suppressed in tests/ via global [defaults], no per-rule config needed"

    def test_global_exclusion_does_not_suppress_production_code(self):
        """Global defaults only exclude test files, not production code."""
        code = "exec(user_input)\n"
        assert findings_for_rule(code, "PY305", filename="runner.py", in_tests_dir=False) != [], \
            "PY305 must still fire in production code"

    def test_pickle_not_suppressed_by_global_defaults(self):
        """
        pickle.loads is a TRUE POSITIVE even in test files — it should still
        fire because the [defaults] deliberately excludes test paths, and
        pickle is a legitimate critical finding anywhere.

        NOTE: if a project adds pickle to a test mock intentionally and wants
        to suppress, they can use # noqa or a per-file override.
        """
        # pickle in a non-test file must still fire
        code = "import pickle\nvalue = pickle.loads(data)\n"
        assert findings_for_rule(code, "PY002", filename="cache.py", in_tests_dir=False) != [], \
            "PY002 (pickle.loads) must fire in production code"


# ===========================================================================