Method doGraph

src/tsd/GraphHandler.java:150–292

(final TSDB tsdb, final HttpQuery query)

  // so we should refactor both classes to split the actual logic used to
  // generate the data from the actual visualization (removing all duped code).
  private void doGraph(final TSDB tsdb, final HttpQuery query)
    throws IOException {
    final String basepath = getGnuplotBasePath(tsdb, query);
    long start_time = DateTime.parseDateTimeString(
      query.getRequiredQueryStringParam("start"),
      query.getQueryStringParam("tz"));
    final boolean nocache = query.hasQueryStringParam("nocache");
    if (start_time == -1) {
      throw BadRequestException.missingParameter("start");
    } else {
      // temp fixup to seconds from ms until the rest of TSDB supports ms
      // Note you can't append this to the DateTime.parseDateTimeString() call as
      // it clobbers -1 results
      start_time /= 1000;
    }
    long end_time = DateTime.parseDateTimeString(
        query.getQueryStringParam("end"),
        query.getQueryStringParam("tz"));
    final long now = System.currentTimeMillis() / 1000;
    if (end_time == -1) {
      end_time = now;
    } else {
      // temp fixup to seconds from ms until the rest of TSDB supports ms
      // Note you can't append this to the DateTime.parseDateTimeString() call as
      // it clobbers -1 results
      end_time /= 1000;
    }
    final int max_age = computeMaxAge(query, start_time, end_time, now);
    if (!nocache && isDiskCacheHit(query, end_time, max_age, basepath)) {
      return;
    }

    // Parse TSQuery from HTTP query
    final TSQuery tsquery = QueryRpc.parseQuery(tsdb, query);
    tsquery.validateAndSetQuery();

    // Build the queries for the parsed TSQuery
    Query[] tsdbqueries = tsquery.buildQueries(tsdb);

    List<String> options = null;
    final String options_allow_list = tsdb.getConfig().getString(
        "tsd.gnuplot.options.allowlist");
    if (!Strings.isNullOrEmpty(options_allow_list)) {
      String[] allow_list_strings = options_allow_list.split(";");
      Set<String> allow_list = Sets.newHashSet();
      for (int i = 0; i < allow_list_strings.length; i++) {
        String allow = allow_list_strings[i];
        if (allow != null) {
          allow = URLDecoder.decode(allow.trim());
          allow_list.add(allow);
        }
      }
      
      options = query.getQueryStringParams("o");
      for (int i = 0; i < options.size(); i++) {
        if (!allow_list.contains(options.get(i))) {
          throw new BadRequestException("Query option at index " + i 
              + " was not in the allow list.");