Function update_provider_record

crates/openshell-server/src/grpc/provider.rs:176–282

(
    store: &Store,
    provider: Provider,
)

}

pub(super) async fn update_provider_record(
    store: &Store,
    provider: Provider,
) -> Result<Provider, Status> {
    use crate::persistence::{ObjectId, ObjectName};

    if provider.object_name().is_empty() {
        return Err(Status::invalid_argument("provider.name is required"));
    }

    // Extract expected version from provider metadata
    let expected_resource_version = provider.metadata.as_ref().map_or(0, |m| m.resource_version);

    // Resolve provider ID from name for CAS update
    let existing = store
        .get_message_by_name::<Provider>(provider.object_name())
        .await
        .map_err(|e| Status::internal(format!("fetch provider failed: {e}")))?;

    let Some(existing) = existing else {
        return Err(Status::not_found("provider not found"));
    };

    // Provider type is immutable after creation. Reject if the caller
    // sends a non-empty type that differs from the existing one.
    let incoming_type = provider.r#type.trim();
    if !incoming_type.is_empty() && !incoming_type.eq_ignore_ascii_case(existing.r#type.trim()) {
        return Err(Status::invalid_argument(
            "provider type cannot be changed; delete and recreate the provider",
        ));
    }

    let current_version = existing.metadata.as_ref().map_or(0, |m| m.resource_version);

    let cas_version = if expected_resource_version == 0 {
        current_version
    } else {
        expected_resource_version
    };

    // Apply merge to create candidate
    let mut candidate = existing.clone();
    candidate.credentials = merge_map(candidate.credentials, provider.credentials);
    candidate.config = merge_map(candidate.config, provider.config);
    candidate.credential_expires_at_ms = merge_i64_map(
        candidate.credential_expires_at_ms,
        provider.credential_expires_at_ms,
    );

    // Validate BEFORE writing to prevent persisting invalid state.
    // Validate only the mutable fields (credentials/config) plus metadata and
    // attached-sandbox invariants. The immutable name/type are carried forward
    // from `existing` and re-running full `validate_provider_fields` here would
    // strand legacy records whose stored type predates current limits. See
    // #1347.
    super::validation::validate_object_metadata(candidate.metadata.as_ref(), "provider")?;
    validate_provider_mutable_fields(&candidate)?;
    validate_provider_update_against_attached_sandboxes(store, &candidate).await?;