ed25519-unsafe-libs

Double Public Key Signing Function Oracle Attack on Ed25519

A list of potentially unsafe ed25519 signature libraries that allow a public api where secret and public key can be provided independently as signing function inputs. Misuse of these public apis can result to private key exposure.

Μost of the repositories in our analysis are enlisted in IANIX :: Things that use Ed25519.

Number of impacted libraries: 45

Number of libraries that fixed the issue after the announcement: 8

last updated: May 04, 2023

Proof of Concept implementations that demonstrate this potential exploit:

• Rust: ed25519-chalkias-exploit
• Python: Ed25519 Vulnerability in Python, Buchanan, William J (2022). Ed25519 Vulnerability in Python (Recovering Private Key). Asecuritysite.com.

Talks:

• Invited talk to USA's National Institute of Standards and Technology (NIST) Crypto Reading Club: slides - Taming the Many EdDSAs (pages 28-39), Konstantinos Chalkias, François Garillot, Valeria Nikolaenko (2023). Taming the Many EdDSAs & Ed25519 Signing Attacks.

News and social network coverage of this attack

• NIST Crypto Reading Club "Taming the Many EdDSAs" (March 08, 2023)
• The Daily Swig "Dozens of cryptography libraries vulnerable to private key theft" (June 28, 2022)
• Risky Biz News "New crypto vulnerability: Tens of cryptography libraries have misimplemented the Ed25519 digital signature algorithm" (June 28, 2022)
• SafeHeron blogpost "Analysis on Ed25519 Use Risks: Your Wallet Private Key Can Be Stolen" (June 17, 2022)
• kryptera.se "Vulnerability in most ed25519 libraries" (in Swedish) (June 29, 2022)
• Difesa e Sicurezza & Yoroi "Librerie crittografiche ed25519 potenzialmente non sicure" (in Italian) (July 1 & June 29, 2022)
• Medium post by Prof Bill Buchanan OBE "Ed25519 is Great, But ..." (July 1, 2022)
• Reddit r/crypto (best post of the month - June 18, 2022)
• Reddit r/cryptography (June 17, 2022)
• Interesting tweets:
  • tweet 1 (by Kostas Kryptos - "The original 26 vulnerable libs")
  • tweet 2 (by Kostas Kryptos - "Aftermath of the 40 vulnerable libs")
  • tweet 3 (by Catalin Cimpanu - "40 cryptography libraries are impacted by same Ed25519 misimplementation")
  • tweet 4 (by Kenny Paterson - "Potential for widespread EdDSA private key recovery, cf. http://kopenpgp.com where same vector exploited in OpenPGP libs")
  • tweet 5 (by Steven Galbraith - "A hazard for deterministic signatures: better check it is the correct public key!")
  • tweet 6 (by Riyaz Faizullabhoy - "If you’re using EdDSA in prod please take a look")
  • tweet 7 (by Bart Preneel - "Reminder that implementing cryptographic algorithms securely and correctly is hard").
• CTF (capture the flag) challenges that feature this attack:
  • ImaginaryCTF - JWT25519 (200pts) (June 30, 2022)

What is the issue?

Note that normally and according to the related rfc8032, EdDSA signatures are deterministic, and thus for the same input message to be signed, a unique signature output that includes two elements, a curve point R and a scalar S, is returned.

An algorithmic detail is that that signer's public key is involved in the deterministic computation of the S part of the signature only, but not in the R value. The latter implies that if an adversary could somehow use the signing function as an Oracle (that expects arbitrary public keys as inputs), then it is possible that for the same message one can get two signatures sharing the same R and only differ on the S part. Unfortunately, when this happens, one can easily extract the private key; this StackOverflow post post explains why this is feasible.

That said, public apis should NOT allow a decoupled private/public key-pair as signing input. To circumvent that, many implementations store the public key along with the private key (or seed) and consider the whole keypair as the secret OR they always re-derive the public key inside the signing function. Unfortunately, a large number of existing libraries fail to address this issue by allowing arbitrary public keys as inputs without checking if the input public key corresponds to the input private key.

Of course, this does not mean that all applications with dependencies to these libraries are prone to key exposure attacks; actually, most are probably safe due to usually not publicly exposing the affected api to their users and coupling their pub/priv key pair just before the sign invocation. On the other hand, even when these apis are not exposed, there are applications with different TCB threat model strategies on how the private and public keys are managed and stored. That said, to prevent this attack, developers should also enforce an integrity protection protocol for the public keys as well.

Here, we enlist some affected libraries along with the related code-references.

Fig 1. An example api misuse in the ed25519-dalek Rust crate.

Affected libraries

• C: OpenGNB

https://github.com/gnbdev/opengnb/blob/master/libs/ed25519/sign.c#L7

• C: GNU Nettle

https://github.com/gnutls/nettle/blob/fe7ae87d1b837e82f7c7968b068bca7d853a4cec/ed25519-sha512-sign.c#L43

• ASM/C: iroha-ed25519 (Hyperledger Project)

https://github.com/hyperledger/iroha-ed25519/blob/main/lib/ed25519/ref10/ed25519.c#L27 and https://github.com/hyperledger/iroha-ed25519/blob/main/lib/ed25519/amd64-64-24k-pic/ed25519.c#L30

• C: ed25519-donna (Andrew Moon)

https://github.com/floodyberry/ed25519-donna/blob/master/ed25519.c#L59

• C: ed25519 (Orson Peters)

https://github.com/orlp/ed25519/blob/master/src/sign.c#L7

• C: libbrine (Kevin Smith)

https://github.com/kevsmith/libbrine/blob/master/src/ed25519/sign.c#L7

• C++: Ed25519 (ArduinoLibs)

https://rweather.github.io/arduinolibs/classEd25519.html#a36ecf67b4c5d2d39a31888f56af1f8a5

• C#: ed25519 (Hans Wolff)

https://github.com/hanswolff/ed25519/blob/master/Ed25519/Ed25519.cs#L146

• C#: Ed25519 (CryptoManiac)

https://github.com/CryptoManiac/Ed25519/blob/972829ac688847895d5105f19ca1e5777131b421/Chaos.NaCl/Internal/Ed25519Ref10/keypair.cs#L7

• Dart: ed25519_dart (Oleksii Semeshchuk)

https://github.com/semolex/ed25519_dart/blob/master/lib/src/ed25519_dart_base.dart#L200

• Dart: riclava_ed25519 (riclava)

https://github.com/riclava/ed25519/blob/master/lib/ed25519.dart#L125

• Clojure: ed25519 (Kevin Downey)

https://github.com/hiredman/ed25519/blob/master/src/ed25519/core.clj#L168

• Haskell: hs-scraps (Vincent Hanquez)

https://github.com/vincenthz/hs-scraps/blob/master/Crypto/Signature/Ed25519.hs#L115

• Java: ed25519-java (k3d3)

https://github.com/k3d3/ed25519-java/blob/master/ed25519.java#L144

• Java: ed25519 (Bjorn Arnelid)

https://github.com/BjornArnelid/ed25519/blob/master/src/ed25519/application/Ed25519.java#L32

• Java: Punisher.NaCl (Arpan Jati)

https://github.com/arpanj/Punisher.NaCl/blob/c9619ca3028b90d0556c0473e4eba1d429a3744c/Punisher.NaCl/src/Punisher/NaCl/Ed25519Operations.java#L72

• Java: ED25519 (Mick Michalski)

https://github.com/michami/ED25519/blob/master/ED25519.java#L60

• Java: vRallev/ECC-25519 (Ralf Wondratschek)

https://github.com/vRallev/ECC-25519/blob/master/ECC-25519-Java/src/main/java/net/vrallev/java/ecc/Ecc25519Helper.java#L102

• Perl: Crypt::Ed25519 (Marc Lehmann)

https://metacpan.org/release/MLEHMANN/Crypt-Ed25519-0.9/view/Ed25519.pm#$signature-=-Crypt::Ed25519::sign-$message,-$public_key,-$private_key

• Python: ed25519.py (Ed25519 authors)

https://ed25519.cr.yp.to/python/ed25519.py

• Python: ed25519 (Python Cryptographic Authority)

https://github.com/pyca/ed25519/blob/main/ed25519.py#L243 (authors mention it’s unsafe against side channels anyway)

• Python: python-pure25519 (Brian Warner)

https://github.com/warner/python-pure25519/blob/master/pure25519/eddsa.py#L21

• Python: nmed25519 (naturalmessage)

https://github.com/naturalmessage/nmed25519/blob/master/nmed25519.py#L150

• Python: ed25519.py (Shiho Midorikawa)

https://gist.github.com/elliptic-shiho/f41fd75cc30646a61d7ad63043fdd56e#file-ed25519-py-L77

• Python: bindings for ed25519-dalek: py-ed25519-bindings

https://github.com/polkascan/py-ed25519-bindings/blob/master/src/lib.rs#L111

• Swift: ed25519swift (pebble8888)

https://github.com/pebble8888/ed25519swift/blob/master/Ed25519ref/ed25519s.swift#L120

• JS: supercop.js (1p6 Flynx)

https://github.com/1p6/supercop.js/blob/master/index.js#L29

• JS: substack/ed25519-supercop (James Halliday)

https://github.com/substack/ed25519-supercop/blob/master/index.js#L3

• C: libeddsa (Philipp Lay)

https://github.com/phlay/libeddsa/blob/master/lib/ed25519-sha512.c#L85

• C#: SommerEngineering/Ed25519 (Thorsten Sommer)

https://github.com/SommerEngineering/Ed25519/blob/master/Ed25519/Signer.cs#L80

• CUDA: ChorusOne/solanity

https://github.com/ChorusOne/solanity/blob/master/src/cuda-ecc-ed25519/sign.cu#L10

• C: ncme/c25519 (Daniel Beer and Nikolas Rösener)

[https://github.com/ncme/c25519/blob/master/src/edsign.c#L115](https://github.com/ncme/c