Function TestWriteOutboxRow_PgNotifyFailureIsSoft

internal/webhookpub/outbox_test.go:128–153

TestWriteOutboxRow_PgNotifyFailureIsSoft pins the C2 fix: when pg_notify fails (realistically: NOTIFY queue overflow at ~8MB), writeOutboxRow MUST log and return nil so the caller's tx commits. Before the fix the pg_notify error was returned, propagating out of PublishTx → out of WithTx → causing t

(t *testing.T)

// NOTIFY fired. The NOTIFY is a latency optimization, not a correctness
// primitive.
func TestWriteOutboxRow_PgNotifyFailureIsSoft(t *testing.T) {
	notifyErr := errors.New("ERROR: too many notifications in the NOTIFY queue (SQLSTATE 54000)")
	fe := &fakeExec{
		errOnContains: "pg_notify",
		errSelective:  notifyErr,
	}
	e := Event{
		ID:     "evt_notify_fail",
		Type:   EventEmailReceived,
		UserID: "u_42",
	}
	if err := writeOutboxRow(context.Background(), fe, e); err != nil {
		t.Fatalf("writeOutboxRow should swallow pg_notify failure, got: %v", err)
	}
	// Both Exec calls must have been attempted — the INSERT first, then
	// the (failing) pg_notify. The INSERT must NOT have been skipped.
	if len(fe.calls) != 2 {
		t.Fatalf("expected 2 Exec calls (INSERT + NOTIFY), got %d: %v", len(fe.calls), fe.calls)
	}
	if !strings.Contains(fe.calls[0], "INSERT INTO webhook_events") {
		t.Errorf("first call must be the INSERT: %s", fe.calls[0])
	}
	if !strings.Contains(fe.calls[1], "pg_notify") {
		t.Errorf("second call must be the pg_notify: %s", fe.calls[1])
	}
}

// TestWriteOutboxRow_InsertFailureStillPropagates ensures the soft-
// failure treatment for pg_notify doesn't accidentally swallow INSERT