Function ExtractNumAndNonNum

src/opt.cpp:25–52

For microinstructions with two or more operands (in l and r), check to see if one of them is numeric and the other one isn't. If this is the case, return pointers to the operands in the appropriately-named argument variables and return true. Otherwise, return false.

// For microinstructions with two or more operands (in l and r), check to see if one of them is numeric and the other one isn't.
// If this is the case, return pointers to the operands in the appropriately-named argument variables and return true. Otherwise, return false.
bool ExtractNumAndNonNum(minsn_t* insn, mop_t*& numOp, mop_t*& otherOp)
{
	mop_t* num = NULL, * other = NULL;

	//check right hand before
	if (insn->r.t == mop_n) {
		num = &insn->r;
		other = &insn->l;
	}

	//check left hand only for commutative ops
	if (insn->opcode != m_sub) {
		if (insn->l.t == mop_n) {
			if (num != NULL) {
				// Technically we have an option to perform constant folding here... but Hex-Rays should have done / should do that for us
				return false;
			}
			num = &insn->l;
			other = &insn->r;
		}
	}
	if (num == NULL)
		return false;

	numOp = num;
	otherOp = other;
	return true;
}

// For microinstructions with two or more operands (in l and r), check to see
// if one of them is a mop_d (result of another microinstruction), where the