Class TestGetMsfConsole

tests/test_helpers.py:211–255

Test the get_msf_console context manager.

class TestGetMsfConsole:
    """Test the get_msf_console context manager."""

    @pytest.fixture
    def mock_client(self):
        """Fixture providing a mock MSF client."""
        client = Mock()
        with patch('MetasploitMCP.get_msf_client', return_value=client):
            yield client

    @pytest.mark.asyncio
    async def test_get_msf_console_success(self, mock_client):
        """Test successful console creation and cleanup."""
        mock_console = MockMsfConsole('test-console-123')
        mock_client.consoles.console.return_value = mock_console
        mock_client.consoles.destroy.return_value = 'destroyed'

        # Mock the global client instance for cleanup
        with patch('MetasploitMCP._msf_client_instance', mock_client):
            async with get_msf_console() as console:
                assert console is mock_console
                assert console.cid == 'test-console-123'

            # Verify cleanup was called
            mock_client.consoles.destroy.assert_called_once_with('test-console-123')

    @pytest.mark.asyncio
    async def test_get_msf_console_creation_error(self, mock_client):
        """Test console creation error handling."""
        mock_client.consoles.console.side_effect = MockMsfRpcError("Console creation failed")
        
        with pytest.raises(MockMsfRpcError, match="Console creation failed"):
            async with get_msf_console() as console:
                pass

    @pytest.mark.asyncio 
    async def test_get_msf_console_cleanup_error(self, mock_client):
        """Test that cleanup errors don't propagate."""
        mock_console = MockMsfConsole('test-console-123')
        mock_client.consoles.console.return_value = mock_console
        mock_client.consoles.destroy.side_effect = Exception("Cleanup failed")
        
        # Should not raise exception even if cleanup fails
        async with get_msf_console() as console:
            assert console is mock_console


class TestRunCommandSafely: