Function validate_completion

mcp_server.py:1639–1735

🚨 MANDATORY validation step for all background agents before indicating completion.

(
    arguments: dict[str, Any], project_root: Path
)

async def validate_completion(
    arguments: dict[str, Any], project_root: Path
) -> CallToolResult:
    """🚨 MANDATORY validation step for all background agents before indicating completion."""
    task_description = arguments.get("task_description", "Code changes")
    run_full_test_suite = arguments.get("run_full_test_suite", True)

    result_text = f"# 🚨 COMPLETION VALIDATION FOR: {task_description}\n\n"
    result_text += "## MANDATORY PRE-COMPLETION CHECK\n\n"
    result_text += (
        "This tool MUST be run by all background agents before indicating completion.\n"
    )
    result_text += "Running comprehensive test suite to ensure all changes are working correctly.\n\n"

    validation_failed = False

    # First, validate Arduino.h includes
    result_text += "### Validating Arduino.h Includes\n\n"
    try:
        arduino_validation = await validate_arduino_includes(
            {
                "directory": "src",
                "include_examples": False,
                "check_dev": False,
                "show_approved": False,
            },
            project_root,
        )

        if arduino_validation.isError:
            validation_failed = True
            result_text += "[ERROR] **ARDUINO.H VALIDATION FAILED**\n\n"
            result_text += "New Arduino.h includes detected! This violates FastLED coding standards.\n"
            result_text += "Please remove Arduino.h includes and use FastLED's platform abstractions instead.\n\n"
        else:
            result_text += "[OK] **Arduino.h validation passed**\n\n"

    except Exception as e:
        result_text += f"⚠️ **Arduino.h validation error:** {str(e)}\n\n"

    if run_full_test_suite:
        result_text += "### Running Full Test Suite: `bash test`\n\n"

        try:
            # Run the bash test command as specified in user rules
            test_result = await run_command(["bash", "test"], project_root)

            # Check if tests passed by looking for common failure indicators
            if (
                "FAILED" in test_result
                or "ERROR" in test_result
                or "error:" in test_result.lower()
            ):
                validation_failed = True
                result_text += (
                    "[ERROR] **VALIDATION FAILED - TESTS CONTAIN ERRORS**\n\n"
                )
                result_text += "```\n" + test_result + "\n```\n\n"