Function run_upload

ci/debug_attached.py:250–323

Upload firmware to device. This function uses `pio run -t upload` which will upload the firmware. PlatformIO's incremental build system only rebuilds if source files changed since the last compilation, making this fast when nothing changed. On Windows Git Bash: Runs via cmd.exe wit

(
    build_dir: Path,
    environment: str | None = None,
    upload_port: str | None = None,
    verbose: bool = False,
)

def run_upload(
    build_dir: Path,
    environment: str | None = None,
    upload_port: str | None = None,
    verbose: bool = False,
) -> bool:
    """Upload firmware to device.

    This function uses `pio run -t upload` which will upload the firmware.
    PlatformIO's incremental build system only rebuilds if source files changed
    since the last compilation, making this fast when nothing changed.

    On Windows Git Bash: Runs via cmd.exe with clean environment (no Git Bash indicators)
    On other platforms: Runs directly with UTF-8 environment

    Args:
        build_dir: Project directory containing platformio.ini
        environment: PlatformIO environment to upload (None = default)
        upload_port: Serial port to use (None = auto-detect)
        verbose: Enable verbose output

    Returns:
        True if upload succeeded, False otherwise.
    """
    cmd = [
        "pio",
        "run",
        "--project-dir",
        str(build_dir),
        "-t",
        "upload",
    ]
    if environment:
        cmd.extend(["--environment", environment])
    if upload_port:
        cmd.extend(["--upload-port", upload_port])
    if verbose:
        cmd.append("--verbose")

    print("=" * 60)
    print("UPLOADING")
    print("=" * 60)

    formatter = TimestampFormatter()
    # Use create_pio_process() for Git Bash compatibility
    proc = create_pio_process(
        cmd,
        cwd=build_dir,
        output_formatter=formatter,
        auto_run=True,
    )

    try:
        # 15 minute timeout per CLAUDE.md standards
        while line := proc.get_next_line(timeout=900):
            if isinstance(line, EndOfStream):
                break
            print(line)