Class UnitTestChecker

ci/lint_cpp/unit_test_checker.py:163–219

Checker that flags: 1. Direct #include "doctest.h" (should use "test.h") 2. Bare doctest macros (should use FL_ prefixed versions)

class UnitTestChecker(FileContentChecker):
    """Checker that flags:
    1. Direct #include "doctest.h" (should use "test.h")
    2. Bare doctest macros (should use FL_ prefixed versions)
    """

    def __init__(self) -> None:
        self.violations: dict[str, list[tuple[int, str]]] = {}

    def should_process_file(self, file_path: str) -> bool:
        if not file_path.startswith(str(TESTS_ROOT)):
            return False
        if not file_path.endswith((".cpp", ".h", ".hpp")):
            return False
        from pathlib import Path

        if Path(file_path).name in EXEMPT_FILES:
            return False
        return True

    def check_file_content(self, file_content: FileContent) -> list[str]:
        violations: list[tuple[int, str]] = []

        for line_number, line in enumerate(file_content.lines, 1):
            stripped = line.strip()

            # Skip line comments
            if stripped.startswith("//"):
                continue

            # Check 1: direct doctest.h include
            if '#include "doctest.h"' in stripped or "#include <doctest.h>" in stripped:
                violations.append(
                    (
                        line_number,
                        'Use #include "test.h" instead of #include "doctest.h"',
                    )
                )

            # Check 2: bare doctest macros
            # Two-phase approach for speed:
            # Phase 1: fast substring check with small prefix set
            if not any(pfx in line for pfx in _FAST_PREFIXES):
                continue

            # Phase 2: single combined regex finds which macro matched
            for match in _COMBINED_BANNED_RE.finditer(line):
                macro_name = match.group(1)
                fl_ver = BANNED_MACROS.get(macro_name)
                if fl_ver is not None:
                    violations.append(
                        (line_number, f"Use {fl_ver}() instead of bare {macro_name}()")
                    )

        if violations:
            self.violations[file_content.path] = violations
        return []